Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URI with query parameter #2861

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Fix URI with query parameter #2861

merged 1 commit into from
Sep 21, 2023

Conversation

snjeza
Copy link
Contributor

@snjeza snjeza commented Sep 20, 2023

@snjeza
Fix URI with query parameter
d9235ba 
Signed-off-by: Snjezana Peco <[email protected]>
@rgrunber rgrunber added this to the End September 2023 milestone Sep 20, 2023
@rgrunber
Copy link
Contributor

Looks like canonicalFilePathFromURI is exclusively used on parsing the root path / workspace folder paths sent as part of initialize, so it's sanitized going forward. I'll just have a closer look at that, but looks mostly fine to me.

The only other place where we wouldn't want to do this are the jdt:// URIs but those don't get touched by this method.

@rgrunber rgrunber merged commit 4d41c29 into eclipse-jdtls:master Sep 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gorkem gorkem Awaiting requested review from gorkem

@fbricon fbricon Awaiting requested review from fbricon

@rgrunber rgrunber Awaiting requested review from rgrunber

@jdneo jdneo Awaiting requested review from jdneo

@testforstephen testforstephen Awaiting requested review from testforstephen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
End September 2023
Development

Successfully merging this pull request may close these issues.

[1.22.1] couldn't create connection to server (Code: -32603)
2 participants
@snjeza @rgrunber