Ensure line delimiter exists after the file header template. #2906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When a file header template is defined there should be a line delimiter between it and the package declaration (or type declaration) - Use project configured line delimiter instead of '\n' where possible Signed-off-by: Roland Grunberg <[email protected]>
rgrunber
force-pushed
the
fix-newcu-fileheader
branch
from
feb6c71
to
0b47851
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
java.templates.fileHeaderdefined. When a type is annotated asSampleClass cannot be resolved to a Type, theCreate {class|interface|enum} SampleClasscode action produces :This regressed in d8e5236#diff-253491dd873df873b33c21cb35ead8d713dd6ac01d2a5b0d2cf91ce5b3f942b9R122 . I must have tried to make all templates containing
${filecomment}${package_declaration}look the same, and so removed the newline from the "newtype" template, not realizing we manually add a line delimiter for the snippet type declaration templates but not for "newtype"