Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete large number of files that duplicate files in jdt.core.manipulations #2947

Merged
merged 6 commits into from
Dec 8, 2023

Conversation

robstryker
Copy link
Contributor

No description provided.

@rgrunber
Copy link
Contributor

add to whitelist

@rgrunber
Copy link
Contributor

rgrunber commented Nov 30, 2023

If the remaining failures are related to the "LTK extension contribution issue", feel free to try something like :

diff --git a/org.eclipse.jdt.ls.target/org.eclipse.jdt.ls.tp.target b/org.eclipse.jdt.ls.target/org.eclipse.jdt.ls.tp.target
index 78ff0fe9..e88ae47c 100644
--- a/org.eclipse.jdt.ls.target/org.eclipse.jdt.ls.tp.target
+++ b/org.eclipse.jdt.ls.target/org.eclipse.jdt.ls.tp.target
@@ -25,7 +25,7 @@
             <unit id="org.eclipse.sdk.feature.group" version="0.0.0"/>
             <unit id="org.mockito.mockito-core" version="0.0.0"/>
             <unit id="org.apache.commons.commons-io" version="0.0.0"/>
-            <repository location="https://download.eclipse.org/eclipse/updates/4.30-I-builds/I20231030-1800/"/>
+            <repository location="https://download.eclipse.org/eclipse/updates/4.31-I-builds/I20231129-1800/"/>
         </location>
         <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
             <unit id="org.eclipse.xtext.xbase.lib" version="0.0.0"/>
@@ -63,4 +63,4 @@
            </location>
     </locations>
     <targetJRE path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-17"/>
-</target>
\ No newline at end of file
+</target>

for testing. Better yet, I may end up creating a separate PR just for that. because the latest I-builds should include some performance improvements for organize imports, as well as basic string template (Java 21) support. Might be nice to have that as a separate PR.

@robstryker
Copy link
Contributor Author

Failing tests are waiting for eclipse-jdt/eclipse.jdt.ui#921, which has failing tests of its own. What a mess.

@@ -25,7 +25,7 @@
<unit id="org.eclipse.sdk.feature.group" version="0.0.0"/>
<unit id="org.mockito.mockito-core" version="0.0.0"/>
<unit id="org.apache.commons.commons-io" version="0.0.0"/>
<repository location="https://download.eclipse.org/eclipse/updates/4.30-I-builds/I20231030-1800/"/>
<repository location="https://download.eclipse.org/eclipse/updates/4.31-I-builds/I20231203-1800/"/>
Copy link
Contributor

@rgrunber rgrunber Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably get rid of this file from the change. #2994 is merged.

@rgrunber
Copy link
Contributor

rgrunber commented Dec 8, 2023

I would just undo the .classpath file changes. I don't think they're needed at all. The project uses the target platform file provided to build, and although we use Maven itself to provide the dependencies under org.eclipse.jdt.ls.core/lib, those get auto-downloaded even without changing the .classpath metadata.

@rgrunber rgrunber merged commit 5d4aeb4 into eclipse-jdtls:master Dec 8, 2023
6 of 7 checks passed
@rgrunber rgrunber changed the title Issue 2946 - Delete large number of files that duplicate files in jdt.core.manipulations Delete large number of files that duplicate files in jdt.core.manipulations Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete large number of files that duplicate files in jdt.core.manipulations
2 participants