Bulk generate getter and setter

[testforstephen]

Signed-off-by: Jinbo Wang [email protected]

Add a Source Action to bulk generate Getters and Setters for all possible fields.

Issues: #163, redhat-developer/vscode-java#597

[fbricon]

the source action needs to have an id that can eventually be bindable by a key shortcut

[fbricon]

The getter/setter code action should not be returned if 0 edits were computed.

Result: [
    {
        "title": "Generate Getters and Setters",
        "kind": "source",
        "diagnostics": [],
        "command": {
            "title": "Generate Getters and Setters",
            "command": "java.apply.workspaceEdit",
            "arguments": [
                {
                    "changes": {
                        "file:///Users/fbricon/Desktop/Standalones/Maths.java": []
                    }
                }
            ]
        }
    },
    {
        "title": "Organize imports",
        "kind": "source.organizeImports",
        "diagnostics": [],
        "command": {
            "title": "Organize imports",
            "command": "java.apply.workspaceEdit",
            "arguments": [
                {
                    "changes": {
                        "file:///Users/fbricon/Desktop/Standalones/Maths.java": []
                    }
                }
            ]
        }
    }

(same thing for organize imports BTW)

[fbricon]

I opened #894 about the empty code actions. I'll provide a separate PR once I've written some tests

[testforstephen]

@fbricon About the bindable id, do you mean we need add a new kind in lsp4j.CodeActionKind for bulk generate getter and setter?

[fbricon]

Create a new kind in jdt.ls, whose prefix will be one of the lsp4j ones. Look if the Js/ts server has something similar, for inspiration

[testforstephen]

There are only source, source.organizeImports in ts server. And looks like vscode doesn't recognize new customized source action kind, such as source.generateGetterSetter.

[fbricon]

please squash your commits and ensure you fix the merge conflicts. Existing CodeActionHandlerTest tests should not be modified

[fbricon]

don't use all caps for enum name

[fbricon]

package org.eclipse.jdt.ls.core.internal.codemanipulation;

org.eclipse.jdt.ls.core.internal.corext.codemanipulation should only be used for code copied from jdt.ui

[fbricon]

Note that source action key mapping is broken in VS Code.

[fbricon]

Create a constant for jdt.ls specific kinds.
SOURCE_ACTION_GENERATE_KIND = CodeActionKind.Source+".generate";
SOURCE_ACTION_GENERATE_ACCESSORS_KIND = SOURCE_ACTION_GENERATE_KIND+".accessors";

Use SOURCE_ACTION_GENERATE_ACCESSORS_KIND

[fbricon]

Kinds are hierarchical, so you need to also change ClientPreferences#isSupportedCodeActionKind so that it accepts sub kinds :

	public boolean isSupportedCodeActionKind(String kind) {
		//@formatter:off
		return v3supported && capabilities.getTextDocument().getCodeAction() != null
				&& capabilities.getTextDocument().getCodeAction().getCodeActionLiteralSupport() != null
				&& capabilities.getTextDocument().getCodeAction().getCodeActionLiteralSupport().getCodeActionKind() != null
				&& capabilities.getTextDocument().getCodeAction().getCodeActionLiteralSupport().getCodeActionKind().getValueSet() != null
				&& capabilities.getTextDocument().getCodeAction().getCodeActionLiteralSupport().getCodeActionKind().getValueSet()
				.stream().filter(k -> kind.startsWith(k)).findAny().isPresent();
		//@formatter:on
	}

[testforstephen]

@fbricon PR updated.

• Squash commit.
• Fix bindable key.
• Address other comments.

[fbricon]

So we're now copying EPL-2 code into a project that hasn't moved to EPL-2 yet (EPL-1 is deprecated, so we should do it eventually). I think this is fine, but would love to get confirmation about it from a professional (@waynebeaton ?)