-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PropertyConfigHandler doesn't seem to be used - in Gradle #296
Comments
12 tasks
It's actually used through the However, since this class relies on Plexus (Maven) injection, it might not be working as expected for Gradle |
manusa
changed the title
PropertyConfigHandler doesn't seem to be used
PropertyConfigHandler doesn't seem to be used - in Gradle
Jul 14, 2023
This was referenced May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
PropertyConfigHandler seems to be completely ignored, same as DockerComposeConfigHandler.
Functionality in ImageConfigResolver#resolve seems to be also something useless at the moment: https://github.com/eclipse/jkube/blob/9db93fb42d1dcade59278ce8f1b433b869e0927d/jkube-kit/build/service/docker/src/main/java/org/eclipse/jkube/kit/build/service/docker/config/handler/ImageConfigResolver.java#L72-L87
Apparently this is something that's already advised/warned in the docs:
https://github.com/eclipse/jkube/blob/9db93fb42d1dcade59278ce8f1b433b869e0927d/kubernetes-maven-plugin/doc/src/main/asciidoc/inc/_introduction.adoc#L215-L218
But the code responsible for this has been included in the project nonetheless.
We need to reevaluate if this code+functionality is relevant in the project and act accordingly.
The text was updated successfully, but these errors were encountered: