Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TBD DefaultGeneratorManager and PropertyResolution #3051

Open
manusa opened this issue May 15, 2024 · 0 comments
Open

TBD DefaultGeneratorManager and PropertyResolution #3051

manusa opened this issue May 15, 2024 · 0 comments

Comments

@manusa
Copy link
Member

manusa commented May 15, 2024

Description

WIP

The recent changes from #3042 and #296, allow to override ImageConfiguration and its BuildConfiguration (and other nested configs) settings by using properties.

However, at the moment, this will only work for projects that have a configured image (i.e. this won't work for generated container images).

We might want to change the structure of the DefaultGeneratorManager:generateAndMerge method so that resolution of properties is performed as the last step.

From the user's perspective this means that settings can be overridden with (common) properties.

Technically, this means that we don't need to duplicate properties or resolve them twice. At the moment, we are using Generator properties and configs (see BaseGenerator).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant