Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of indexer, everywhere #509

Closed
mickaelistria opened this issue Jan 21, 2022 · 14 comments · Fixed by #510
Closed

Get rid of indexer, everywhere #509

mickaelistria opened this issue Jan 21, 2022 · 14 comments · Fixed by #510
Milestone

Comments

@mickaelistria
Copy link
Contributor

Maven indexer is an unhealthy project, and it relies on downloading indexes, which is a pretty expensive operation that is typically not desired as there are better alternatives.
m2e should soon initiate an effort to remove everything that relies on indexer and stop relying on indexer for anything.

@mickaelistria
Copy link
Contributor Author

I reviewed usage of indexer and the only important use-case is about Archetype. However, we can usually load artifacts without an index, so this could probably be removed there.

@HannesWell
Copy link
Contributor

Fully support! This will save me about 4GB of disk-space per workspace that uses M2E.

To remove the indexer the old editor has to be removed before, right?
We then also remove the org.eclipse.m2e.maven.indexer plug-in from m2e?

@mickaelistria
Copy link
Contributor Author

This would more or less require to remove most features from Maven Repositories view.

@HannesWell
Copy link
Contributor

Once the indexer is removed we should consider to (automatically) clean up the then unused workspace's indexing-data at \.metadata\.plugins\org.eclipse.m2e.core\nexus. The indexing-data can be huge (for me it is ~4,5GB per workspace that uses m2e!).
This would be convenient and could be done in the activator of org.eclipse.m2e.core.
We could ask the user in a dialog if the deletion should be performed or not or just delete the old files if they are present?

@vogella
Copy link
Contributor

vogella commented Jan 25, 2022

+1 for the removal

@mickaelistria mickaelistria added this to the 2.0.0 milestone Feb 15, 2022
@mickaelistria mickaelistria linked a pull request Mar 11, 2022 that will close this issue
@mickaelistria
Copy link
Contributor Author

Fixed with #510

@HannesWell
Copy link
Contributor

Fixed with #510

🎉 Thank you Mickael!

@ririliu
Copy link

ririliu commented Sep 15, 2022

I update eclipse to new 2022-09 version, which with m2e version 2.0.4, I found "maven repositories" view is broken, all repository include local repository is grey out, and without any icon, and there is no "rebuild index" or "update index" option in context menu, is the problem related to this issue?

@mickaelistria
Copy link
Contributor Author

s the problem related to this issue?

Yes. this view should have been removed entirely to be consistent with the indexer removal.

@ririliu
Copy link

ririliu commented Sep 15, 2022

s the problem related to this issue?

Yes. this view should have been removed entirely to be consistent with the indexer removal.

I found the "search" function in "pom editor"-"Dependencies tab"-"Add..." window need the index, I tried search in eclipse 2022-09, it's not work.
I kind like this search function 🤣

@HannesWell
Copy link
Contributor

You can simply type your search query into the Dependencies section of a pom and the content assist suggests corresponding results.

@ririliu
Copy link

ririliu commented Sep 15, 2022

I mean this window
图片
I don't konw where to find the section you talk about

@laeubi
Copy link
Member

laeubi commented Sep 15, 2022

You can simply type your search query into the Dependencies section of a pom and the content assist suggests corresponding results.

If it not gets stuck forever ...

Also as noted earlier, this is not really a full alternative, beside being buggy/slow it does not allow efficiently scroll, there is no way fro tree like representation as in the screenshot and so on....

@mickaelistria
Copy link
Contributor Author

I mean this window

I think there is already an issue open to replace this window by some integration of search.maven.org service that does a better job than the indexer. If you're willing to contribute a rework of this window, that would be really welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants