Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all indexer #510

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

mickaelistria
Copy link
Contributor

No description provided.

@fbricon
Copy link
Contributor

fbricon commented Jan 21, 2022

This is a breaking change (JBoss Tools depends on the Indexer API), you should update m2e version to 2.0 and advertise it on the mailing list(s).

cc @jeffmaury

@mickaelistria
Copy link
Contributor Author

OK

@laeubi
Copy link
Member

laeubi commented Jan 21, 2022

If we have breaking changes / m2e 2.0 we should also consider removing deprecated APIs.

@mickaelistria
Copy link
Contributor Author

If we have breaking changes / m2e 2.0 we should also consider removing deprecated APIs.

Yes, I'd like to prepare this work but wait a bit before we merge it. I hope we can release a newer m2e with various improvements in the next week or the week after, then we can start a break-fest.

@HannesWell
Copy link
Contributor

If we have breaking changes / m2e 2.0 we should also consider removing deprecated APIs.

Yes, I'd like to prepare this work but wait a bit before we merge it. I hope we can release a newer m2e with various improvements in the next week or the week after, then we can start a break-fest.

That's reasonable. We should announce the breaking changes respectively version 2.0 as early as possible and give the community some time to react.

What functionality we loose
* Search dialog is empty
* Maven Repsitories view doesn't show children
@mickaelistria mickaelistria merged commit 079ad83 into eclipse-m2e:master Mar 11, 2022
@mickaelistria mickaelistria linked an issue Mar 11, 2022 that may be closed by this pull request
@claudioweiler
Copy link

Hi @mickaelistria, everyone!

This also removed capability of using internal maven archetypes.

Any workaround, or plugin that solves this?

@mickaelistria
Copy link
Contributor Author

Can you please open an issue about this failing functionality?

@claudioweiler
Copy link

@mickaelistria , I don't know it this a "failing functionality".

Nexus Indexer was able to find archetypes deployed on internal services (e.g. JFrog Artifactory) and show them in new maven projects wizard.

I found a way to upload a manually generated archetype-catalog.xml to Artifactory, them added a remote catalog (Preferences > Maven > Archetypes).

This solved as workaround, but manually generating archetype-catalog.xml is no good. Maybe Sonatype Nexus handles this, but Artifactory not.

References:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of indexer, everywhere
5 participants