Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a feature out of a maven-target location #280 #376

Closed
wants to merge 12 commits into from

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Oct 14, 2021

First POC for transforming a pom into a feature

This transforms pom artifacts into features.

FYI @HannesWell

This currently requires an ibuild of PDE to work!

First POC for transforming a pom into a feature

Signed-off-by: Christoph Läubrich <[email protected]>
@laeubi
Copy link
Member Author

laeubi commented Oct 21, 2021

@HannesWell the necessary changes should be available with the latest I-build, just let me know what you think about it so far.

@HannesWell
Copy link
Contributor

Thank you Christoph for this draft!
I'm sorry my late response but the work on your PDE Bug 570760 and its associated bugs keeps me busy. PDE is very fragmented and it takes quite some time to get a good overview over all aspects.
I hope to find the time to have a detailed look into this next week.

@laeubi
Copy link
Member Author

laeubi commented Oct 29, 2021

@HannesWell no need to worry... in the meantime, I'm quite fine with the featureset as a first valuable iteration, if no more comments/issues arise, the next would be to wait for the new PDE release....
And when we are quite sure that it is good to go that way, tycho needs to be enhanced to support this as well see

@laeubi laeubi marked this pull request as ready for review December 8, 2021 15:11
Signed-off-by: Christoph Läubrich <[email protected]>
Signed-off-by: Christoph Läubrich <[email protected]>
Signed-off-by: Christoph Läubrich <[email protected]>
Signed-off-by: Christoph Läubrich <[email protected]>
Signed-off-by: Christoph Läubrich <[email protected]>
@laeubi
Copy link
Member Author

laeubi commented Dec 8, 2021

@HannesWell @mickaelistria I have upgraded the target to use the latest 2021-12 release but now it seem I have to bump all versions (at least the build fails with that), is this intentional?

@mickaelistria
Copy link
Contributor

it seem I have to bump all versions (at least the build fails with that), is this intentional?

Try rebasing your change on top of master first.

@laeubi laeubi closed this Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a feature out of a maven-target location
3 participants