Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FillHandle] Improve fault handling #86

Closed
fipro78 opened this issue May 8, 2024 · 0 comments
Closed

[FillHandle] Improve fault handling #86

fipro78 opened this issue May 8, 2024 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@fipro78
Copy link
Contributor

fipro78 commented May 8, 2024

There are two places in the fill handle classes, that currently have negative impact on adapting the fill handle in more complex setups:

  1. FillHandleLayerPainter
    The check if the positionRectangle is valid is missing. The SelectionLayerPainter does such a check, to ensure the the returned rectangle does not contain negative values. If someone wants to extend the FillHandleLayerPainter or uses it in a composition that is different from the defaults, it might happen that there you also get an invalid retangle. In such cases you see a NegativeArraySizeException all over. Therefore we should add the check if the rectangle is valid also to the FillHandleLayerPainter
  2. FillHandlePasteCommandHandler
    Currently the value to paste in the cell is always calculated, whether a cell is editable or not. This is not necessary, and might lead to issues in cases where the calculation is done for a series although the cell is not editable for semantic reasons. The cell value should therefore only be calculated if the cell is editable.
@fipro78 fipro78 self-assigned this May 8, 2024
@fipro78 fipro78 added the bug Something isn't working label May 8, 2024
@fipro78 fipro78 added this to the 2.4.0 milestone May 8, 2024
fipro78 added a commit that referenced this issue May 8, 2024
@fipro78 fipro78 closed this as completed in 8ef0027 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant