Disable sample based recompilation pre-checkpoint under -XX:+DebugOnR…

…estore Disable sample based recompilation pre-checkpoint when -XX:+DebugOnRestore is specified as it does not provide any benefit and can complicate the infrastructure. Signed-off-by: Irwin D'Souza <[email protected]>
eclipse-openj9 · Apr 11, 2024 · f0d24de · f0d24de
1 parent 69956f0
commit f0d24de
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/runtime/compiler/control/HookedByTheJit.cpp b/runtime/compiler/control/HookedByTheJit.cpp
@@ -1369,7 +1369,11 @@ static void jitMethodSampleInterrupt(J9VMThread* vmThread, IDATA handlerKey, voi
            * optimization that statistically should be useful.
            */
           && !compInfo->getCRRuntime()->shouldSuspendThreadsForCheckpoint()
-#endif
+
+          /* Don't sample methods for recompilation pre-checkpoint if Debug On Restore is enabled */
+          && (!jitConfig->javaVM->internalVMFunctions->isCheckpointAllowed(vmThread)
+              || !jitConfig->javaVM->internalVMFunctions->isDebugOnRestoreEnabled(vmThread))
+#endif /* defined(J9VM_OPT_CRIU_SUPPORT) */
           && !compInfo->getPersistentInfo()->getDisableFurtherCompilation())
          {
          static char *enableDebugDLT = feGetEnv("TR_DebugDLT");
@@ -1424,6 +1428,10 @@ static void jitMethodSampleInterrupt(J9VMThread* vmThread, IDATA handlerKey, voi
            * optimization that statistically should be useful.
            */
           && !compInfo->getCRRuntime()->shouldSuspendThreadsForCheckpoint()
+
+          /* Don't sample methods for recompilation pre-checkpoint if Debug On Restore is enabled */
+          && (!jitConfig->javaVM->internalVMFunctions->isCheckpointAllowed(vmThread)
+              || !jitConfig->javaVM->internalVMFunctions->isDebugOnRestoreEnabled(vmThread))
 #endif
           && !compInfo->getPersistentInfo()->getDisableFurtherCompilation())
          {