Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test code/infrastruture should use DYLD_LIBRARY_PATH on OSX JDK11 #3686

Closed
babsingh opened this issue Nov 15, 2018 · 7 comments
Closed

Test code/infrastruture should use DYLD_LIBRARY_PATH on OSX JDK11 #3686

babsingh opened this issue Nov 15, 2018 · 7 comments

Comments

@babsingh
Copy link
Contributor

The following tests are failing in #3603 ... Sanity - JDK11 - osx_x86-64_cmprssptrs:

16:49:38 ---SUMMARY OF FAILED TESTS---
16:49:38 abort  
16:49:38 softwareFloat  
16:49:38 hardwareFloat  
16:49:38 softwareRead  
16:49:38 hardwareRead  
16:49:38 abort thread
16:49:38 softwareFloat thread
16:49:38 hardwareFloat thread
16:49:38 softwareRead thread
16:49:38 hardwareRead thread

The reason for the above test failures is UnsatisfiedLinkError:

16:49:18  [ERR] Exception in thread "main" java.lang.UnsatisfiedLinkError: gptest (Not found in java.library.path)
16:49:18  [ERR] 	at java.base/java.lang.ClassLoader.loadLibraryWithPath(ClassLoader.java:1678)
16:49:18  [ERR] 	at java.base/java.lang.ClassLoader.loadLibraryWithClassLoader(ClassLoader.java:1648)
16:49:18  [ERR] 	at java.base/java.lang.System.loadLibrary(System.java:559)
16:49:18  [ERR] 	at VMBench.GPTests.GPTest.<clinit>(GPTest.java:70)

To fix the above test failures, test infrastructure needs to set DYLD_LIBRARY_PATH on MacOSX instead of LD_LIBRARY_PATH.

fyi - @llxia @smlambert @gacholio

@smlambert
Copy link
Contributor

fyi @renfeiw

@babsingh
Copy link
Contributor Author

babsingh commented Nov 15, 2018

Before tests would hang at Test: abort stage on OSX. To reproduce the above failures locally, you will need the commits in #3603.

@llxia
Copy link
Contributor

llxia commented Nov 15, 2018

@sophia-guo Could you update the lib path for osx? Could you also check if we can use JDK_IMPL instead of JCL_VERSION in if statement. Thanks
https://github.com/eclipse/openj9/blob/80b8e6c420fff2b443b4bc3746c261d37c49a738/test/TestConfig/openj9Settings.mk#L74

@llxia
Copy link
Contributor

llxia commented Nov 20, 2018

Talked with Sophia, I will work on this issue

@babsingh babsingh changed the title Test code/infrastruture should use DYLD_LIBRARY_PATH on MacOSX Test code/infrastruture should use DYLD_LIBRARY_PATH on OSX JDK11 Nov 21, 2018
@babsingh
Copy link
Contributor Author

UnsatisfiedLinkError failures are specific to OSX JDK11. With OSX JDK8, gpTest suite failures are different: gpTest suite failures on OSX with JDK8.

@llxia
Copy link
Contributor

llxia commented Nov 27, 2018

Tests are updated to use DYLD_LIBRARY_PATH on osx in #3765

Since cmdLineTest_gpTest hangs at abort test, it is excluded in #3765.

@babsingh
Copy link
Contributor Author

#3765 is the fix for this issue. Closing this issue since the following exception is no longer seen while running the gpTest suite:

16:49:18  [ERR] Exception in thread "main" java.lang.UnsatisfiedLinkError: gptest (Not found in java.library.path)
16:49:18  [ERR] 	at java.base/java.lang.ClassLoader.loadLibraryWithPath(ClassLoader.java:1678)
16:49:18  [ERR] 	at java.base/java.lang.ClassLoader.loadLibraryWithClassLoader(ClassLoader.java:1648)
16:49:18  [ERR] 	at java.base/java.lang.System.loadLibrary(System.java:559)
16:49:18  [ERR] 	at VMBench.GPTests.GPTest.<clinit>(GPTest.java:70)

make target: _cmdLineTest_gpTest_0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants