J9UNIX support on OSX

[babsingh]

1) Remove dead code - unused variable: envVarSize

2) Update (J9UNIX || OSX) ifdefs

• J9UNIX flag will be enabled for OSX. Thus, replacing ifdefs: (J9UNIX || OSX) -> (J9UNIX).
• Also, formatted J9UNIX ifdefs according to coding standards.

3) Handle outliers where J9UNIX code doesn't apply to OSX

J9UNIX flag is going to be enabled on OSX.

In jvm.c::JVM_Available and jvm.c::JVM_Open, stat and fstat are used on
OSX because stat64 and fstat64 are deprecated on OSX. J9UNIX code uses
stat64 and fstat64, which needs to be disabled on OSX.

In jvm.c::JVM_SetLength, ftruncate is used on OSX and ftruncate64 is used
on J9UNIX. ftruncate64 is unsupported on OSX. So, J9UNIX code related to
ftruncate64 needs to be disabled on OSX.

4) Avoid multiple J9UNIX definitions and enable J9UNIX flag on OSX

Two definitions of J9UNIX, in jvm.h and vmargs.c, have been removed.

A J9UNIX definition has been added in j9comp.h.

In jvm.h, code dependent on J9UNIX has been moved after j9comp.h is
included.

At the end, J9UNIX flag is enabled on OSX.

5) Use DYLD_LIBRARY_PATH on OSX

On OSX, environment variable, DYLD_LIBRARY_PATH, contains library search
paths. So, ENV_LD_LIB_PATH macro should refer to DYLD_LIBRARY_PATH on
OSX.

6) Don't append /usr/lib64 to java.library.path on OSX

/usr/lib64 doesn't exist on OSX. So, it shouldn't be appended to
java.library.path on OSX.

More details about J9UNIX usage available here: #3452.

Closes: #3452

Signed-off-by: Babneet Singh [email protected]

[babsingh]

@gacholio can you please review these changes?

fyi - @pshipton @pdbain-ibm @DanHeidinga

[babsingh]

@gacholio will you be reviewing this pull request?

[gacholio]

I can do - the multiple J9UNIX definition still needs to be updated.

[babsingh]

@gacholio updated PR - refer to commit 4 - Avoid multiple J9UNIX definitions and enable J9UNIX flag on OSX.

[gacholio]

jenkins test sanity plinux jdk8

[gacholio]

jenkins test sanity osx jdk11

[gacholio]

OSX build failing for known reasons.

[gacholio]

I did say "known reason" :)

[babsingh]

OSX JDK11 CI job will work after #3671 is merged.

[babsingh]

@gacholio #3671 was just merged. can you restart the OSX JDK11 CI job?

[gacholio]

jenkins test sanity osx jdk11

[gacholio]

@babsingh Is the pltest failure expected?

[gacholio]

Given that the test failure seems to be unrelated to this PR, I'll merge.

[babsingh]

@gacholio None of the previous OSX JDK11 CI Sanity jobs reached Testing: PLTEST stage. The previous CI jobs seem to be stuck at Testing: abort. These changes resolve the abort hang.

The failure is related to test script mkgen.pl:

17:16:22     echo ""; echo "cmdLineTester_pltest_0""_PASSED"; echo ""; cd /Users/jenkins/workspace/PullRequest-Sanity-JDK11-osx_x86-64_cmprssptrs-OpenJ9/openj9/test/TestConfig/scripts/testKitGen/../../..; rm -f -r "/Users/jenkins/workspace/PullRequest-Sanity-JDK11-osx_x86-64_cmprssptrs-OpenJ9/openj9/test/TestConfig/scripts/testKitGen/../../../TestConfig/test_output_15422313122267/cmdLineTester_pltest_0";
17:16:22 else
17:16:22     echo ""; echo "cmdLineTester_pltest_0""_FAILED"; echo "";
17:16:22 fi; } 2>&1
17:16:22      64364                       | tee -a "/Users/jenkins/workspace/PullRequest-Sanity-JDK11-osx_x86-64_cmprssptrs-OpenJ9/openj9/test/TestConfig/scripts/testKitGen/../../../TestConfig/test_output_15422313122267/TestTargetResult"
17:16:22 make[4]: *** [cmdLineTester_pltest_0] Error 131
17:16:22 make[3]: *** [sanity-pltest] Error 1
17:16:22 make[2]: *** [sanity-cmdLineTests] Error 1
17:16:22 make[1]: *** [sanity-functional] Error 1
17:16:22 make: *** [sanity-..] Error 1

In the above log snippet, the following command is invalid:

64364                       | tee -a "/Users/jenkins/workspace/PullRequest-Sanity-JDK11-osx_x86-64_cmprssptrs-OpenJ9/openj9/test/TestConfig/scripts/testKitGen/../../../TestConfig

Created #3685 for the above PLTEST failure.

Also, the following tests are failing in this PR's Sanity - JDK11 - osx_x86-64_cmprssptrs:

16:49:38 ---SUMMARY OF FAILED TESTS---
16:49:38 abort  
16:49:38 softwareFloat  
16:49:38 hardwareFloat  
16:49:38 softwareRead  
16:49:38 hardwareRead  
16:49:38 abort thread
16:49:38 softwareFloat thread
16:49:38 hardwareFloat thread
16:49:38 softwareRead thread
16:49:38 hardwareRead thread

The reason for the above test failures is UnsatisfiedLinkError:

16:49:18  [ERR] Exception in thread "main" java.lang.UnsatisfiedLinkError: gptest (Not found in java.library.path)
16:49:18  [ERR] 	at java.base/java.lang.ClassLoader.loadLibraryWithPath(ClassLoader.java:1678)
16:49:18  [ERR] 	at java.base/java.lang.ClassLoader.loadLibraryWithClassLoader(ClassLoader.java:1648)
16:49:18  [ERR] 	at java.base/java.lang.System.loadLibrary(System.java:559)
16:49:18  [ERR] 	at VMBench.GPTests.GPTest.<clinit>(GPTest.java:70)

To fix the above test failures, test infrastructure needs to set DYLD_LIBRARY_PATH on MacOSX instead of LD_LIBRARY_PATH. Created #3686 for the above UnsatisfiedLinkError failures.