Improve conceptual integrity of SVM nomenclature

[dsouzai]

The SVM, at its core, maintains a mapping between the results of front end VM queries and uint16_t IDs. Conceptually, the ID is the symbol that is associated with the result which is the value. However, in the SVM, the term "symbol" was used to refer to the value. This is confusing for anyone new to the SVM, especially since it claims to be similar to a symbol table in a linker.

This PR improves the conceptual integrity of the SVM by actually referring to values as values and IDs as symbols.

[dsouzai]

@jdmpapin could you please review?

[dsouzai]

@jdmpapin review reminder for this.

[jdmpapin]

LGTM with a few very minor comments

There's a typo in the commit message of b9f31905 where it says definedGuaranteedID (past/adjective) instead of defineGuaranteedID (imperative)

[dsouzai]

@jdmpapin made the requested changes (including the commit message typo). Good for final review now.

[jdmpapin]

Jenkins test sanity+aot all jdk17

[dsouzai]

Jenkins test sanity+aot all jdk17

[jdmpapin]

/home/jenkins/workspace/Build_JDK17_aarch64_linux_Personal/openj9/runtime/compiler/codegen/J9AheadOfTimeCompile.cpp:1290:61: error: 'class TR::SymbolValidationManager' has no member named 'getIDFromSymbol'; did you mean 'getValueFromSymbolID'?
          thunkRecord->setThunkID(reloTarget, symValManager->getIDFromSymbol(svmRecord->_thunk));
                                                             ^~~~~~~~~~~~~~~
                                                             getValueFromSymbolID
/home/jenkins/workspace/Build_JDK17_aarch64_linux_Personal/openj9/runtime/compiler/codegen/J9AheadOfTimeCompile.cpp:1291:62: error: 'class TR::SymbolValidationManager' has no member named 'getIDFromSymbol'; did you mean 'getValueFromSymbolID'?
          thunkRecord->setMethodID(reloTarget, symValManager->getIDFromSymbol(svmRecord->_method));
                                                              ^~~~~~~~~~~~~~~
                                                              getValueFromSymbolID

Looks like you'll need to rebase and update these lines from #14542

[jdmpapin]

Jenkins test sanity+aot all jdk17

[dsouzai]

jenkins woes again :(

[dsouzai]

Jenkins test sanity+aot all jdk17

[jdmpapin]

Jenkins test sanity+aot all jdk17

[AdamBrousseau]

Jenkins test sanity.functional+aot all jdk17

[dsouzai]

AIX test failed because of

[2022-03-05T02:28:56.690Z]  [ERR] Exception in thread "main" java.awt.AWTError: Can't connect to X11 window server using 'unix:0' as the value of the DISPLAY variable.
[2022-03-05T02:28:56.690Z]  [ERR] 	at java.desktop/sun.awt.X11GraphicsEnvironment.initDisplay(Native Method)
[2022-03-05T02:28:56.690Z]  [ERR] 	at java.desktop/sun.awt.X11GraphicsEnvironment$1.run(X11GraphicsEnvironment.java:101)
...

which, even though it happens on the second run, has been seen before outside of this PR: #14421 (comment)

@jdmpapin This PR should be good for merging now.