Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set gcc 10.3 compiler for JDK17+ on Linux platforms #14791

Merged
merged 1 commit into from
May 19, 2022
Merged

Set gcc 10.3 compiler for JDK17+ on Linux platforms #14791

merged 1 commit into from
May 19, 2022

Conversation

vsebe
Copy link
Contributor

@vsebe vsebe commented Mar 28, 2022 •
edited by pshipton
Loading

Upgrade gcc from 7.5 to 10.3 for JDK17+ on Linux platforms.
Remove *_linux_gcc10 specs.

Issue: #14268
Closes #14799

Signed-off-by: Violeta Sebe [email protected]

@vsebe
Copy link
Contributor Author

vsebe commented Mar 28, 2022

Jenkins compile xlinux,zlinux,plinux,alinux64 jdk18

@vsebe
Copy link
Contributor Author

vsebe commented Mar 28, 2022

Jenkins compile xlinux jdk18

@pshipton
Copy link
Member

Setting to draft as we are waiting on performance evaluation before merging this.

@pshipton pshipton marked this pull request as draft March 28, 2022 14:52
@vsebe vsebe force-pushed the openj9_gcc10 branch 3 times, most recently from e550ce5 to 6bdb84a Compare March 28, 2022 15:19
@vsebe
Copy link
Contributor Author

vsebe commented Mar 28, 2022

Jenkins compile xlinux jdk8,jdk11

@vsebe vsebe mentioned this pull request Mar 28, 2022
Closed
@vsebe
Copy link
Contributor Author

vsebe commented Mar 28, 2022

Jenkins compile xlinux jdk8

@pshipton
Copy link
Member

@vsebe pls update this so jdk17 is updated as well.

@pshipton
Copy link
Member

Also update the commit comment to mention the change is for jdk17+.

@vsebe vsebe changed the title Set gcc 10.3 compiler for Linux platforms Set gcc 10.3 compiler for JDK17+ on Linux platforms May 10, 2022
@vsebe vsebe force-pushed the openj9_gcc10 branch 2 times, most recently from d248f94 to 7ca2d07 Compare May 10, 2022 19:21
@vsebe
Copy link
Contributor Author

vsebe commented May 10, 2022

Jenkins compile xlinux,zlinux,plinux,alinux64 jdk17

@vsebe
Copy link
Contributor Author

vsebe commented May 10, 2022

Jenkins compile x86-64_linux_criu jdk17

@pshipton
Copy link
Member

Full testing of gcc 10.3 is happening in these builds:
https://openj9-jenkins.osuosl.org/job/Pipeline-Build-Test-Personal/146/
https://openj9-jenkins.osuosl.org/job/Pipeline-Build-Test-Personal/147/

There is an apparent regression on plinux in test ContendedFieldsTests_90_1. There are 4 sub-test failures which are all similar, the first as follows.

FAILED: testContentionGroupsAndClass
java.lang.AssertionError: org.openj9.test.contendedfields.TestClasses$ContGroupContClass calculated size 128 actual size 24 difference -104
	at org.testng.AssertJUnit.fail(AssertJUnit.java:59)
	at org.testng.AssertJUnit.assertTrue(AssertJUnit.java:24)
	at org.openj9.test.contendedfields.FieldUtilities.checkObjectSize(FieldUtilities.java:67)
	at org.openj9.test.contendedfields.ContendedFieldsTests.testContentionGroupsAndClass(ContendedFieldsTests.java:201)

@pshipton pshipton mentioned this pull request May 10, 2022
Merged
@pshipton
Copy link
Member

For the cause of the failure see #15056

@AdamBrousseau AdamBrousseau mentioned this pull request May 13, 2022
Closed
@pshipton
Copy link
Member

@vsebe pls fix the merge conflict and remove this from draft.

@vsebe
Set gcc 10.3 compiler for JDK17+ on Linux platforms
9b127e0 
Upgrade gcc from 7.5 to 10.3 for JDK17+ on Linux platforms.
Remove *_linux_gcc10 specs.

Issue: eclipse-openj9#14268

Signed-off-by: Violeta Sebe <[email protected]>
@vsebe vsebe marked this pull request as ready for review May 19, 2022 12:48
@pshipton pshipton mentioned this pull request May 19, 2022
Closed
@pshipton
Copy link
Member

Created doc issue eclipse-openj9/openj9-docs#938

@pshipton
Copy link
Member

jenkins compile alinux64,xlinux,plinux,zlinux jdk8,jdk11,jdk17,jdk18

@pshipton pshipton merged commit 739cf71 into eclipse-openj9:master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton approved these changes

Assignees
No one assigned
Labels
comp:build depends:doc
Projects
None yet
Milestone
Release 0.33 (Java 8, 11, 17, 18) Jul...
Development

Successfully merging this pull request may close these issues.

Change jdk17 linux compilers to gcc 10.3
2 participants
@vsebe @pshipton