-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match jdk8 runFinalizersOnExit() and phantom reference behavior #15784
Conversation
2a9d924
to
99d4fde
Compare
jenkins test sanity,sanity.openjdk alinux64,zlinux,aix,win,win32 jdk8 depends ibmruntimes/openj9-openjdk-jdk8#openj9-staging |
4ff7465
to
cb238cf
Compare
jenkins test sanity,sanity.openjdk alinux64,zlinux,aix,win,win32 jdk8 depends ibmruntimes/openj9-openjdk-jdk8#openj9-staging |
jenkins test sanity,sanity.openjdk alinux64,zlinux,aix,win,win32 jdk8 depends ibmruntimes/openj9-openjdk-jdk8#openj9-staging |
The zlinux sanity.functional tests passed, but because I aborted a restart it appears aborted in the summary. The passing job is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GC part of the change looks good to me
Added a link to the spec change to the description. |
test/functional/Java8andUp/src_80/org/openj9/test/java/lang/Test_System.java
Outdated
Show resolved
Hide resolved
test/functional/Java8andUp/src_80/org/openj9/test/java/lang/Test_System.java
Outdated
Show resolved
Hide resolved
FYI There is now a jdk8u352-b04 level which hasn't yet been tested. |
80ae727
to
1578c76
Compare
runFinalizersOnExit() now throws UnsupportedOperationException. OpenJDK issue 8287132. Signed-off-by: Peter Shipton <[email protected]>
The runFinalizersOnExit() API now throws UnsupportedOperationException. OpenJDK issue 8287132. Signed-off-by: Peter Shipton <[email protected]>
Match the behavior of Java 11+ Signed-off-by: Peter Shipton <[email protected]>
Signed-off-by: Peter Shipton <[email protected]>
Signed-off-by: Peter Shipton <[email protected]>
Addressed review comments. Rebasing, and I'll run a new jdk8 acceptance build with this change on jdk8u352-b04. |
1578c76
to
7835b77
Compare
jkd8 acceptance build with this change https://openj9-jenkins.osuosl.org/job/Pipeline-OpenJDK8-Acceptance/45/ |
jenkins test sanity amac jdk11 |
OpenJDK issues:
8287132: Retire Runtime.runFinalizersOnExit so that it always throws UOE
8071507: (ref) Clear phantom reference as soft and weak references do
Spec change: https://jcp.org/aboutJava/communityprocess/maintenance/jsr337/jsr337-mr4-changes.html
This change depends on the jdk8 openj9-staging branch, which needs to be promoted at the same time this is merged.