Post Restore Options Processing Part 4 (0.38) #16876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless specified pre-checkpoint, the compiler generates will generate code assuming these options are not set. If these options are then specified post-restore, the options processing code will invalidate all JIT code in the code cache, as well as prevent further AOT compilation (since the AOT method header would have already been validated). Signed-off-by: Irwin D'Souza <[email protected]>
The Checkpoint phase is conceptually part of building the application; therefore it does not make sense to expect a user who specifies an option such as `-XsamplingExpirationTime` to take into account the time spent executing in the Checkpoint phase. Therefore, on restore, both the start and elapsed time are reset. Signed-off-by: Irwin D'Souza <[email protected]>
Signed-off-by: Irwin D'Souza <[email protected]>
|
@mpirvu could you please merge? |
mpirvu
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #16852