Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JIT Hooks Document #16973

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Update JIT Hooks Document #16973

merged 1 commit into from
Apr 17, 2023

Conversation

dsouzai
Copy link
Contributor

@dsouzai dsouzai commented Mar 20, 2023

Update this document with other hooks of interest to the JIT, as well as a note on the importance of the J9HookDisable API used to test whether a hook is enabled (based on the discussion in #16960).

@dsouzai
Copy link
Contributor Author

dsouzai commented Mar 20, 2023

@a7ehuo @0xdaryl could you please review?

Copy link
Contributor

@a7ehuo a7ehuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the doc on JIT Hooks @dsouzai ! Just some very minor comments

doc/compiler/runtime/JITHooks.md Outdated Show resolved Hide resolved
doc/compiler/runtime/JITHooks.md Outdated Show resolved Hide resolved
doc/compiler/runtime/JITHooks.md Outdated Show resolved Hide resolved
doc/compiler/runtime/JITHooks.md Outdated Show resolved Hide resolved
doc/compiler/runtime/JITHooks.md Outdated Show resolved Hide resolved
[ci skip]

Signed-off-by: Irwin D'Souza <[email protected]>
@dsouzai
Copy link
Contributor Author

dsouzai commented Mar 23, 2023

@a7ehuo good for review again.

Copy link
Contributor

@a7ehuo a7ehuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@dsouzai
Copy link
Contributor Author

dsouzai commented Mar 24, 2023

@0xdaryl do you mind reviewing/merging?

@dsouzai
Copy link
Contributor Author

dsouzai commented Mar 30, 2023

@0xdaryl review reminder.

@dsouzai
Copy link
Contributor Author

dsouzai commented Apr 17, 2023

Since Daryl's on vacation, @ymanton do you mind reviewing/merging?

@ymanton ymanton merged commit 9f00c8d into eclipse-openj9:master Apr 17, 2023
@dsouzai dsouzai deleted the vmHooksDoc branch April 3, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants