Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor getStackTraceImpl to remove use of VThreadInspector #17303

Merged
merged 1 commit into from
May 4, 2023

Conversation

fengxue-IS
Copy link
Contributor

This removes JCL's dependency on VirtualThread.notifyJvmti* functions.

Signed-off-by: Jack Lu [email protected]

@fengxue-IS
Copy link
Contributor Author

personal build passed on xlinux sanity.functional/openjdk
@babsingh can you take a look

Copy link
Contributor

@babsingh babsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, I suggest adding a full-stop at the end of all comments in the two functions.

runtime/jcl/common/getstacktrace.c Outdated Show resolved Hide resolved
runtime/jcl/common/getstacktrace.c Show resolved Hide resolved
runtime/jcl/common/getstacktrace.c Outdated Show resolved Hide resolved
runtime/jcl/common/getstacktrace.c Outdated Show resolved Hide resolved
runtime/jcl/common/getstacktrace.c Outdated Show resolved Hide resolved
runtime/jcl/common/getstacktrace.c Outdated Show resolved Hide resolved
@fengxue-IS
Copy link
Contributor Author

Updated all comments as suggested. fix issue with object reference.

@babsingh
Copy link
Contributor

babsingh commented May 4, 2023

jenkins test sanity alinux64 jdk20

@babsingh
Copy link
Contributor

babsingh commented May 4, 2023

jenkins test sanity zlinux jdk8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants