Initialize JITServer SSL context post CRIU restore #17797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When encryption is enabled for a JITServer client post CRIU restore, the client needs to update its SSL configuration with the newly provided certificate. This is done in ClientStream::static_init() function which needs to be called during processOptionsPostRestore(). Moreover, if SSL encryption was specified pre-checkpoint, the hook that gets executed, `TR::CompilationInfo::prepareForCheckpoint()`, will delete the existing SSL context and any existing certificate. Issue: eclipse-openj9#17786 Signed-off-by: Marius Pirvu <[email protected]>
mpirvu
added
comp:jitserver
|
I have verified that a JITServer connection is successfully made post restore when the SSL certificate is provided. |
|
@dsouzai Could you please review/merge this PR? Thanks |
|
jenkins test sanity plinuxjit,xlinuxjit,zlinuxjit jdk17 |
|
Tests have passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encryption is enabled for a JITServer client post CRIU restore, the client needs to update its SSL configuration with the newly provided certificate. This is done in
ClientStream::static_init()function which needs to be called duringprocessOptionsPostRestore().Moreover, if SSL encryption was specified pre-checkpoint, the hook that gets executed,
TR::CompilationInfo::prepareForCheckpoint(), will delete the existing SSL context and any existing certificate.Issue: #17786