InstantOn adjust heap size with restore machine #18168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
might want to also update OMR side function just for consistency |
kangyining
changed the title
kangyining
changed the title
amicic
reviewed
Sep 21, 2023
amicic
reviewed
Sep 21, 2023
amicic
reviewed
Sep 21, 2023
|
in subject, i'd say 'adjust' is more appropriate then 'align' |
kangyining
changed the title
amicic
reviewed
Sep 22, 2023
amicic
reviewed
Sep 22, 2023
amicic
reviewed
Sep 22, 2023
amicic
reviewed
Sep 22, 2023
kangyining
changed the title
amicic
reviewed
Sep 22, 2023
amicic
reviewed
Sep 22, 2023
amicic
reviewed
Sep 22, 2023
amicic
reviewed
Sep 22, 2023
kangyining
force-pushed
the
restoreMaxHeap
branch
2 times, most recently
from
65c64c6
to
16546ff
Compare
amicic
reviewed
Sep 25, 2023
|
add some more info into PR description how we treat a couple of special cases (when we ignore and proceed vs when we fail) |
kangyining
force-pushed
the
restoreMaxHeap
branch
from
390b543
to
36112eb
Compare
Updated, please take a look :) |
|
jenkins test sanity aix,win jdk11 |
kangyining
force-pushed
the
restoreMaxHeap
branch
3 times, most recently
from
d3fc950
to
4c1771f
Compare
amicic
reviewed
Nov 16, 2023
amicic
approved these changes
Nov 16, 2023
|
PR comment should match the commit comment |
kangyining
force-pushed
the
restoreMaxHeap
branch
2 times, most recently
from
7f47e5a
to
89bc6d3
Compare
amicic
reviewed
Nov 16, 2023
kangyining
force-pushed
the
restoreMaxHeap
branch
from
89bc6d3
to
464f866
Compare
dmitripivkine
approved these changes
Nov 20, 2023
When we snapshot on a machine with higher physical memory and restore on one with lower physical memory, the InstantOn JVM heap size will be larger than a usual JVM run on the restore machine. And the momory usage will be abnormally higher. Update the extension with the correct physical memory limit and utilize the existing softmax mechanism to solve the problem. Note we only update the softmax if it is smaller than the Xmx size. If it is smaller than the Xms size, then we upscale the softmx to match with the Xms size. Related: eclipse-openj9#17596 Detailed behavior table: eclipse-openj9#18217 (comment) Signed-off-by: Frank Kang [email protected]
kangyining
force-pushed
the
restoreMaxHeap
branch
from
464f866
to
f3e0870
Compare
|
jenkins test sanity.functional xLinux jdk21 |
|
jenkins test sanity win,aix jdk11 |
|
1 'elapse time' failure on Windows. Seems unrelated. Merging.... |
This was referenced Mar 5, 2024
kangyining
added a commit
to kangyining/openj9
that referenced
this pull request
Mar 12, 2024
Add supporting test cases and related testing scripts. Softmx functionalities: eclipse-openj9#18168 Functional changes: eclipse-openj9#19037
kangyining
added a commit
to kangyining/openj9
that referenced
this pull request
Mar 13, 2024
Add supporting test cases and related testing scripts. Softmx functionalities: eclipse-openj9#18168 Functional changes: eclipse-openj9#19037
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust heap size for CRIU restore
When we snapshot on a machine with higher physical memory and restore on one
with lower physical memory, the InstantOn JVM heap size will be larger than
a usual JVM run on the restore machine. And the momory usage will be abnormally
higher.
Update the extension with the correct physical memory limit and utilize the
existing softmax mechanism to solve the problem. Note we only update the softmax
if it is smaller than the Xmx size. If it is smaller than the
Xms size, then we upscale the softmx to match with the Xms size.
Related:
#17596
Detailed behavior table:
#18217 (comment)
Signed-off-by: Frank Kang [email protected]