Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate FSD code pre-checkpoint under -XX:+DebugOnRestore #18894

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

dsouzai
Copy link
Contributor

@dsouzai dsouzai commented Feb 5, 2024

  • Generate FSD code pre-checkpoint under -XX:+DebugOnRestore; reset to non-FSD code post-restore
  • Add -XX:+DebugOnRestore variation for some CRIU tests

@dsouzai dsouzai added comp:test comp:jit criu Used to track CRIU snapshot related work labels Feb 5, 2024
@dsouzai
Copy link
Contributor Author

dsouzai commented Feb 5, 2024

@ymanton do you mind reviewing this PR?

If -XX:+DebugOnRestore is specified, generate FSD code pre-checkpoint.
This commit does not ensure that performance is maintained; it merely
includes the changes needed to generate FSD code pre-checkpoint and
non-FSD code post-restore.

Signed-off-by: Irwin D'Souza <[email protected]>
Copy link
Member

@ymanton ymanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ymanton
Copy link
Member

ymanton commented Feb 12, 2024

Jenkins test sanity.functional xlinux,plinux,zlinux,alinux64 jdk17

@ymanton ymanton merged commit 5775ab9 into eclipse-openj9:master Feb 13, 2024
11 checks passed
@dsouzai dsouzai deleted the fsdPreCheckpoint branch April 3, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jit comp:test criu Used to track CRIU snapshot related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants