Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support interpreter re-entry for CRIU debug support #18903

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

gacholio
Copy link
Contributor

@gacholio gacholio commented Feb 6, 2024

Add a new private flag which instructs the interpreter to exit and re-invoke itself. This will be used by CRIU when a restored image requests debug capabilities (by changing the interpreter entry point to the debug interpreter).

Related: #17642

Add a new private flag which instructs the interpreter to exit and
re-invoke itself. This will be used by CRIU when a restored image
requests debug capabilities (by changing the interpreter entry point to
the debug interpreter).

Related: eclipse-openj9#17642

Signed-off-by: Graham Chapman <[email protected]>
@gacholio gacholio added comp:vm criu Used to track CRIU snapshot related work labels Feb 6, 2024
@gacholio gacholio requested a review from tajila February 6, 2024 15:45
@gacholio
Copy link
Contributor Author

gacholio commented Feb 6, 2024

Use VM_VMHelpers::requestInterpreterReentry(targetThread) to request re-entry.

@tajila
Copy link
Contributor

tajila commented Feb 6, 2024

jenkins test sanity win jdk8

@tajila
Copy link
Contributor

tajila commented Feb 6, 2024

jenkins test sanity plinux jdk21

@tajila tajila merged commit d210643 into eclipse-openj9:master Feb 7, 2024
7 checks passed
@gacholio gacholio deleted the criu branch February 7, 2024 13:20
@@ -49,6 +49,8 @@ FUNC_LABEL(cInterpreter):
blr x28
cmp x0, {#}J9TR_bcloop_exit_interpreter
beq .L_cInterpExit
cmp x0, {#}J9TR_bcloop_reenter_interpreter
beq FUNC_LABEL(cInterpreter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing closing parenthesis?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:vm criu Used to track CRIU snapshot related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants