Fix virtual thread interrupts #18989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JasonFengJ9 Can you please review this change? It is related to OJDK's Thread impl. |
|
Also, requesting @tajila for a review. |
JasonFengJ9
reviewed
Feb 23, 2024
babsingh
force-pushed
the
main6
branch
5 times, most recently
from
806dfa5
to
a99b9fd
Compare
In JDK19+, multiple thread objects can be associated to a J9VMThread: a virtual thread and its carrier thread. If a virtual thread is mounted, then the carrier thread is unmounted and vice-versa. In such cases, J9VMThread's state should not be used to determine if a thread object is interrupted. Instead, Thread.interrupted is used to determine if a thread object is interrupted. If a mounted thread is suspended, only set Thread.interrupted to TRUE and do not wake/interrupt the thread. This behaviour is expected in GetThreadStateMountedTest, which is a test added for virtual threads in JDK22. These changes are only added for virtual threads in JDK19+. Related: eclipse-openj9#18810 Signed-off-by: Babneet Singh <[email protected]>
tajila
approved these changes
Feb 29, 2024
|
jenkins test sanity alinux64 jdk21 |
|
jenkins test sanity win jdk8 |
|
The Windows test build failed due to #18998: |
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
Feb 29, 2024
Depends on eclipse-openj9/openj9#18989 Closes: eclipse-openj9/openj9#18810 Signed-off-by: Babneet Singh <[email protected]>
smlambert
pushed a commit
to adoptium/aqa-tests
that referenced
this pull request
Mar 1, 2024
Depends on eclipse-openj9/openj9#18989 Closes: eclipse-openj9/openj9#18810 Signed-off-by: Babneet Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JDK19+, multiple thread objects can be associated to a J9VMThread:
a virtual thread and its carrier thread.
If a virtual thread is mounted, then the carrier thread is unmounted and
vice-versa. In such cases, J9VMThread's state should not be used to
determine if a thread object is interrupted.
Instead, Thread.interrupted is used to determine if a thread object is
interrupted.
If a mounted thread is suspended, only set Thread.interrupted to TRUE
and do not wake/interrupt the thread. This behaviour is expected in
GetThreadStateMountedTest, which is a test added for virtual threadsin JDK22. These changes are only added for virtual threads in JDK19+.
Related: #18810