Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix acquireVMaccessIfNeeded for Non-Compiler Threads #19260

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Fix acquireVMaccessIfNeeded for Non-Compiler Threads #19260

merged 3 commits into from
Apr 5, 2024

Commits on Apr 3, 2024

  1. Fix acquireVMaccessIfNeeded for Non-Comp Threads 

    Whena a non-comp thread invokes acquireVMaccessIfNeeded, the function
silently returns, because it assumes that a non-comp thread should
already have had VMAccess. This is particularly problematic when using
TR::VMAccessCriticalSection, as it is not at all obvious that the
current thread may not actually have VMAccess. Furthermore, there are
legitmate circusmtances when a non-comp thread will not have VMAccess
and will need to use this API to acquire it.

Signed-off-by: Irwin D'Souza <[email protected]>
    @dsouzai
    dsouzai committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    aecb627 View commit details
    Browse the repository at this point in the history

  2. Enforce VMAccess when calling compileMethod 

    Signed-off-by: Irwin D'Souza <[email protected]>
    @dsouzai
    dsouzai committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    eb960eb View commit details
    Browse the repository at this point in the history

  3. Use TR::VMAccessCriticalSection in dumpIPBCDataCallGraph 

    Signed-off-by: Irwin D'Souza <[email protected]>
    @dsouzai
    dsouzai committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    48359c5 View commit details
    Browse the repository at this point in the history