Delay AOT validation until restore under -XX:+DebugOnRestore #19316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsouzai
added
comp:jit
comp:jit:aot
criu
21 tasks
|
@mpirvu could you please review? |
|
@mpirvu review reminder. |
|
jenkins test sanity all jdk17 |
|
Build failure: |
|
Ah, I didn't guard the static field initialization with |
Under -XX:+DebugOnRestore, the JIT generates FSD code. This is problematic for AOT as either: 1. An existing SCC will fail validation, since the AOT code therein will not have been generated with FSD, or 2. An unpopulated SCC will contain FSD code, which will be useless for any JVM that does not have FSD enabled This commit delays AOT validation until after restore; this ensures that AOT code from the SCC can be loaded post-restore, and that any code added to the SCC is maximally sharable. Signed-off-by: Irwin D'Souza <[email protected]>
dsouzai
force-pushed
the
delayAOTCriuFSD
branch
from
5facf9e
to
b1bcfa7
Compare
|
jenkins test sanity all jdk17 |
|
win64 failure because all nodes were offline |
|
Merging since tests have passed (windows failures are due to infra) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under -XX:+DebugOnRestore, the JIT generates FSD code. This is problematic for AOT as either:
This commit delays AOT validation until after restore; this ensures that AOT code from the SCC can be loaded post-restore, and that any code added to the SCC is maximally sharable.
Parent issue: #18866