Disable OMR_THR_YIELD_ALG on MacOS #3921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OMR_THR_YIELD_ALG enables support for -Xthr:[cfsYield|noCfsYield]. [cfsYield|noCfsYield] should only be used with Completely Fair Scheduler (CFS). MacOS schedulers can be classified as multilevel feedback queue schedulers. MacOS doesn't use CFS. Thus, disabling OMR_THR_YIELD_ALG on MacOS. Signed-off-by: Babneet Singh <[email protected]>
|
fyi - @DanHeidinga |
|
@DanHeidinga @pshipton can this be merged? |
|
jenkins test sanity osx jdk8,jdk11 |
pshipton
approved these changes
Jan 14, 2019
dnakamura
added a commit
to dnakamura/openj9
that referenced
this pull request
May 27, 2020
Since its only enabled on linux platforms, move it from common.cmake to linux.cmake See eclipse-openj9#3921 Signed-off-by: Devin Nakamura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OMR_THR_YIELD_ALG enables support for -Xthr:[cfsYield|noCfsYield].
[cfsYield|noCfsYield] should only be used with Completely Fair Scheduler
(CFS).
MacOS schedulers can be classified as multilevel feedback queue
schedulers. MacOS doesn't use CFS. Thus, disabling OMR_THR_YIELD_ALG on
MacOS.
Signed-off-by: Babneet Singh [email protected]