Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable class sharing by default on OSX #4079

Merged
merged 1 commit into from
Dec 18, 2018
Merged

Enable class sharing by default on OSX #4079

merged 1 commit into from
Dec 18, 2018

Conversation

hangshao0
Copy link
Contributor

@hangshao0 hangshao0 commented Dec 17, 2018 •
edited by pshipton
Loading

Closes #3333

Doc issue eclipse-openj9/openj9-docs#149

Signed-off-by: hangshao [email protected]

@hangshao0 hangshao0 mentioned this pull request Dec 17, 2018
Closed
@pshipton
Copy link
Member

jenkins test sanity osx jdk11

@pshipton
Copy link
Member

jenkins test sanity osx jdk8

@pshipton pshipton mentioned this pull request Dec 17, 2018
Closed
@pshipton
Copy link
Member

jenkins compile osx jdk8

@pshipton
Copy link
Member

jenkins compile osx jdk8

1 similar comment
@pshipton
Copy link
Member

jenkins compile osx jdk8

@pshipton
Copy link
Member

jenkins test sanity osx jdk11

@pshipton
Copy link
Member

jenkins compile osx jdk8

@pshipton
Copy link
Member

@hangshao0 I notice there is a test excluded via #3333 here https://github.com/eclipse/openj9/blob/82c8e950375ca004e6ae370bf47421f96e63fbc8/test/functional/cmdLineTests/shareClassTests/SCCMLTests/playlist.xml#L400
If it was excluded because of the AOT problem then it should be enabled again before #3333 is closed.

@AdamBrousseau
Copy link
Contributor

jenkins test sanity osx jdk8

1 similar comment
@AdamBrousseau
Copy link
Contributor

jenkins test sanity osx jdk8

@pshipton
Copy link
Member

Not seeing any new failures in sanity testing.
I note this problem can still occur, in jdk8 testing on osx1011-x86-2

 [ERR] JVMSHRC659E An error has occurred while opening shared memory
 [ERR] JVMSHRC336E Port layer error code = -393970
 [ERR] JVMSHRC337E Platform error message: shmget : Cannot allocate memory
 [ERR] JVMSHRC029E Not enough memory left on the system

@pshipton
Copy link
Member

jenkins test sanity osx jdk8,jdk11

@hangshao0
Copy link
Contributor Author

I notice there is a test excluded via #3333 here...

The change to enable this test on OSX is in this PR.

@pshipton pshipton merged commit 353ac57 into eclipse-openj9:master Dec 18, 2018
@DanHeidinga DanHeidinga mentioned this pull request Jan 9, 2019
Closed
@pshipton pshipton mentioned this pull request Jun 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton approved these changes

Assignees
No one assigned
Labels
comp:vm depends:doc
Projects
None yet
Milestone
Release 0.12.0 (Java 8, 11 Jan refresh)
Development

Successfully merging this pull request may close these issues.
3 participants
@hangshao0 @pshipton @AdamBrousseau