Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Import Licenses" wizard should support import from archive #1191

Closed
ruspl-afed opened this issue Dec 17, 2022 · 3 comments · Fixed by #1285
Closed

"Import Licenses" wizard should support import from archive #1191

ruspl-afed opened this issue Dec 17, 2022 · 3 comments · Fixed by #1285
Assignees
@eparovyshnaya
Labels
component::runtime Passage Licensing Runtime (LIC): reused accross other components
Milestone
2.11.0

Comments

@ruspl-afed
Copy link
Contributor

"Import Licenses" wizard requires to point to a folder, that typically recieved from outside in the form of archive.

It would be great to recognize licensing information from unpacked archive directly,
@ruspl-afed ruspl-afed added the component::runtime Passage Licensing Runtime (LIC): reused accross other components label Dec 17, 2022
@eparovyshnaya eparovyshnaya added this to the 2.7.0 milestone Dec 17, 2022
@ruspl-afed ruspl-afed modified the milestones: 2.7.0, 2.8.0 Mar 16, 2023
@ruspl-afed ruspl-afed removed this from the 2.8.0 milestone Jun 4, 2023
@eparovyshnaya eparovyshnaya added this to the 2.11.0 milestone Jan 17, 2024
@eparovyshnaya
Copy link
Contributor

At least (or even rather) we should supply a way to particpate in this part of ui so passage-integrating project could define for themselves how they prefer to gain a license file from end user

eparovyshnaya added a commit that referenced this issue Feb 18, 2024
@eparovyshnaya
[#1191] "Import Licenses" wizard should support import from archive
302bb55 
ImportLicenseDialog is extended with proper hooks
@eparovyshnaya eparovyshnaya mentioned this issue Feb 18, 2024
Merged
eparovyshnaya added a commit that referenced this issue Feb 19, 2024
@eparovyshnaya
[#1191] "Import Licenses" wizard should support import from archive
fd8eaf7 
ImportLicenseDialog is extended with proper hooks
eparovyshnaya added a commit that referenced this issue Feb 19, 2024
@eparovyshnaya
[#1191] "Import Licenses" wizard should support import from archive
5f20368 
license headers
eparovyshnaya added a commit that referenced this issue Feb 19, 2024
@eparovyshnaya
[#1191] "Import Licenses" wizard should support import from archive
470e75b 
add javadoc
eparovyshnaya added a commit that referenced this issue Feb 19, 2024
@eparovyshnaya
[#1191] "Import Licenses" wizard should support import from archive (#…
3028013 
…1285)

* [#1191] "Import Licenses" wizard should support import from archive

ImportLicenseDialog is extended with proper hooks

* [#1191] "Import Licenses" wizard should support import from archive

ImportLicenseDialog is extended with proper hooks

* [#1191] "Import Licenses" wizard should support import from archive

add javadoc

---------

Co-authored-by: eparovyshnaia <[email protected]>
@eparovyshnaya
Copy link
Contributor

ImportLicenseDialog is extended with proper hooks, as well as all the chain of inclusions that make your custom dialog work.

  • construct you verion of ImportLicenseDialog with custom LicenseFilesControl implementation (read license files from archive, for instance).
  • supply it to LicenseStatusDialog by defining your own version of BaseLicenseStatusDialog
  • supply your version of BaseLicenseStatusDialog to your version of BaseEquinoxPassageUI
  • which you can directly invoke from your own version of E4LicensingAddon or other places

eparovyshnaya added a commit that referenced this issue Feb 19, 2024
@eparovyshnaya
[#1191] "Import Licenses" wizard should support import from archive
bf2e832 
predefined layout for all the contributed control gets a way for conform
appearance
@eparovyshnaya
Copy link
Contributor

eparovyshnaya commented Feb 19, 2024 •
edited
Loading

result could be looking, for instance, like that:
image

eparovyshnaya added a commit that referenced this issue Feb 19, 2024
@eparovyshnaya
[#1191] "Import Licenses" wizard should support import from archive
fbd5b60 
predefined layout for all the contributed control gets a way for conform
appearance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eparovyshnaya eparovyshnaya

Labels
component::runtime Passage Licensing Runtime (LIC): reused accross other components
Projects
None yet
Milestone
2.11.0
Development

Successfully merging a pull request may close this issue.

[#1191] "Import Licenses" wizard should support import from archive eclipse-passage/passage
2 participants
@eparovyshnaya @ruspl-afed