Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1237] Align target with SimRel 2023-09 #1243

Merged
merged 1 commit into from
Aug 23, 2023
Merged

[#1237] Align target with SimRel 2023-09 #1243

merged 1 commit into from
Aug 23, 2023

Conversation

ruspl-afed
Copy link
Contributor

Switch to notarized version of JNA

@ruspl-afed
Copy link
Contributor Author

@merks do I need to do anything else with JNA to align with SimRel?

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #1243 (cba596a) into master (1d55e62) will not change coverage.
The diff coverage is n/a.

❗ Current head cba596a differs from pull request most recent head c010259. Consider uploading reports for the commit c010259 to get more accurate results

@@            Coverage Diff            @@
##             master    #1243   +/-   ##
=========================================
  Coverage     33.48%   33.48%           
  Complexity      359      359           
=========================================
  Files          1175     1175           
  Lines         25744    25744           
  Branches       1590     1590           
=========================================
  Hits           8620     8620           
  Misses        16603    16603           
  Partials        521      521           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@merks
Copy link
Contributor

merks commented Aug 23, 2023

@merks do I need to do anything else with JNA to align with SimRel?

The direct from maven version is not currently causing Mac notarization problems but it has in the past. Using the one with signed *.jnilib from https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/milestone/latest would be advisable.

Switch to notarized version of JNA

Signed-off-by: Alexander Fedorov <[email protected]>
Copy link
Contributor

@eparovyshnaya eparovyshnaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вот как...

@eparovyshnaya eparovyshnaya merged commit c549ebd into master Aug 23, 2023
2 of 3 checks passed
@merks
Copy link
Contributor

merks commented Aug 23, 2023

Thank you. 😃

@merks
Copy link
Contributor

merks commented Aug 23, 2023

FYI, you could consider to update your oshi dependency:

https://github.com/eclipse-orbit/orbit-simrel/blob/main/report/maven-osgi/passage/REPORT.md

@ruspl-afed
Copy link
Contributor Author

Thank you Ed @merks , we will consider this dependency update if new version of oshi will work well for us

@ruspl-afed ruspl-afed deleted the 1237-2 branch November 15, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants