Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to changed output directory in maven-javadoc-plugin 3.10.0 #1402

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

HannesWell
Copy link
Member

@HannesWell HannesWell commented Sep 9, 2024

Probably as part of apache/maven-javadoc-plugin#204, the default output directory of the maven-javadoc-plugin changed when updating the maven-javadoc-plugin from 3.8.0 to 3.10.0. This adapts the doc-bundle build accordingly.

In a local test the missing reference/api folder was generated in the project as expected, but the built jar still didn't contain it. So maybe more adaption is necessary.

Hopefully fixes #1392

Copy link

github-actions bot commented Sep 9, 2024

Test Results

   285 files  ±0     285 suites  ±0   52m 15s ⏱️ - 2m 9s
 3 581 tests ±0   3 505 ✅ +2   76 💤 ±0  0 ❌ ±0 
10 935 runs  ±0  10 704 ✅ +2  231 💤 ±0  0 ❌ ±0 

Results for commit a76977a. ± Comparison against base commit d7f7ee3.

@akurtakov
Copy link
Member

Build artifacts look good.

@akurtakov akurtakov merged commit ebb82cf into eclipse-pde:master Sep 10, 2024
17 checks passed
@laeubi
Copy link
Contributor

laeubi commented Sep 10, 2024

Something similar might be required for other doc bundles as well!

@HannesWell HannesWell deleted the fix-1392 branch September 10, 2024 17:46
@HannesWell
Copy link
Member Author

Something similar might be required for other doc bundles as well!

I thought that as well, but at least the tests for the other doc bundles didn't report a problem. Not sure if this is false positive or if PDE is different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

org.eclipse.ua.tests.doc failure since I20240904-0530
3 participants