add trace option for delta tree details that cause rebuilds #45
Conversation
| debugDeltaNode(prefix, found); | ||
| } | ||
| ret = true; | ||
| if (!debugBuildNeededDelta()) |
There was a problem hiding this comment.
bad that the control flow is changed by debugging option. Could that be resolved by copy&paste some code from below?
There was a problem hiding this comment.
The control flow by itself does require to find the first entry matching either Project or InterestingProjects (without need to find all of them), but when debugging I want to see each matching entry.
|
The Jenkins build of this PR has now completed. See details at https://ci.eclipse.org/platform/job/eclipse.platform.resources/job/PR-45/1/ |
| } | ||
|
|
||
| private boolean debugBuildNeededDelta() { | ||
| return Policy.DEBUG_BUILD_NEEDED && Policy.DEBUG_BUILD_NEEDED_DELTA; |
There was a problem hiding this comment.
why should both flags needed to be set?
There was a problem hiding this comment.
The header line "needs building because of changes in" is (and should remain) controlled by DEBUG_BUILD_NEEDED and does make sense without the details, while the delta details make little sense without that header line.
So combining the flags feels necessary in one ("or", for the header) or another ("and", for the details) way.
|
I like the idea. But i am not used to debug options. @kthoms can you help review? |
|
The Jenkins build of this PR has now completed. See details at https://ci.eclipse.org/platform/job/eclipse.platform.resources/job/PR-45/2/ |
|
Updated commit to put the debugging together into one method, and "or" combine the flags. |
|
The Jenkins build of this PR has now completed. See details at https://ci.eclipse.org/platform/job/eclipse.platform.resources/job/PR-45/3/ |
bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/events/BuildManager.java
Outdated
Show resolved
Hide resolved
When builders are detected to need a build, the interesting project name found in the delta tree may not be enough information. Sometimes, each interesting modified resource is necessary to see what's going on. But even without each modified resource, trace each project having delta that needs a builder. Signed-off-by: Michael Haubenwallner <[email protected]>
|
The Jenkins build of this PR has now completed. See details at https://ci.eclipse.org/platform/job/eclipse.platform.resources/job/PR-45/4/ |
When builders are detected to need a build, the interesting project name
found in the delta tree may not be enough information. Sometimes, each
interesting modified resource is necessary to see what's going on.
For me, it was necessary to see that only the project resource was modified (touched) to identify ssi-schaefer/lcdsl/pull/56.