Scaling combo text according to zoom level

Registering the comboDpiChange handler and applying change manually to text, image and arrow Contributes to #62 and #127
eclipse-platform · Jun 19, 2024 · c9c43d0 · c9c43d0
1 parent f708ac3
commit c9c43d0
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/...ernal/CommonWidgetsDPIChangeHandlers.java → ...ustom/CommonWidgetsDPIChangeHandlers.java b/...ernal/CommonWidgetsDPIChangeHandlers.java → ...ustom/CommonWidgetsDPIChangeHandlers.java
@@ -11,9 +11,10 @@
  * Contributors:
  *     Yatta Solutions - initial API and implementation
  *******************************************************************************/
-package org.eclipse.swt.internal;
+package org.eclipse.swt.custom;
 
 import org.eclipse.swt.graphics.*;
+import org.eclipse.swt.internal.*;
 import org.eclipse.swt.widgets.*;
 
 /**
@@ -31,6 +32,7 @@ public class CommonWidgetsDPIChangeHandlers {
 
 	public static void registerCommonHandlers() {
 		DPIZoomChangeRegistry.registerHandler(CommonWidgetsDPIChangeHandlers::handleItemDPIChange, Item.class);
+		DPIZoomChangeRegistry.registerHandler(CommonWidgetsDPIChangeHandlers::handleCComboDPIChange, CCombo.class);
 	}
 
 	private static void handleItemDPIChange(Widget widget, int newZoom, float scalingFactor) {
@@ -43,4 +45,15 @@ private static void handleItemDPIChange(Widget widget, int newZoom, float scalin
 			item.setImage(image);
 		}
 	}
+
+	private static void handleCComboDPIChange(Widget widget, int newZoom, float scalingFactor) {
+		if (!(widget instanceof CCombo)) {
+			return;
+		}
+		CCombo combo = (CCombo) widget;
+
+		DPIZoomChangeRegistry.applyChange(combo.text, newZoom, scalingFactor);
+		DPIZoomChangeRegistry.applyChange(combo.list, newZoom, scalingFactor);
+		DPIZoomChangeRegistry.applyChange(combo.arrow, newZoom, scalingFactor);
+	}
 }
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java b/bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java
@@ -21,6 +21,7 @@
 import java.util.function.*;
 
 import org.eclipse.swt.*;
+import org.eclipse.swt.custom.*;
 import org.eclipse.swt.graphics.*;
 import org.eclipse.swt.internal.*;
 import org.eclipse.swt.internal.ole.win32.*;