Remove obsolete API filter for GCData and Display on MacOS

[HeikoKlare]

Since recent PDE and Tycho changes, the API filters for GCData and Display on MacOS are not necessary anymore and produce warnings due to being obsolete. This removes the according filters.

[github-actions]

Test Results

   486 files  ±0     486 suites  ±0   7m 14s ⏱️ -15s
 4 154 tests ±0   4 146 ✅ ±0   8 💤 ±0  0 ❌ ±0 
16 370 runs  ±0  16 278 ✅ ±0  92 💤 ±0  0 ❌ ±0 

Results for commit 5dc86aa. ± Comparison against base commit 2b675ad.

♻️ This comment has been updated with latest results.

[HeikoKlare]

@laeubi can you say whether this is somehow expected?

I am not sure which PDE change introduced (or rather fixed) this. But since the recent Tycho update (eclipse-platform/eclipse.platform.releng.aggregator#2360), SWT builds fail because of this, e.g., https://github.com/eclipse-platform/eclipse.platform.swt/actions/runs/10941734968/job/30377080455?pr=1378

Error:  Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.9:verify (verify) on project org.eclipse.swt.cocoa.macosx.x86_64: There are API warnings:
Error:  Eclipse SWT/cocoa/org/eclipse/swt/graphics/GCData.java:31 The API problem filter for: 'The field org.eclipse.swt.graphics.GCData.bg is no longer an API' is no longer used
Error:  Eclipse SWT/cocoa/org/eclipse/swt/graphics/GCData.java:31 The API problem filter for: 'The field org.eclipse.swt.graphics.GCData.fg is no longer an API' is no longer used
Error:  Eclipse SWT/cocoa/org/eclipse/swt/widgets/Display.java:106 The API problem filter for: 'The @noextend restriction have been added for type org.eclipse.swt.widgets.Display' is no longer used
Error:  Eclipse SWT/cocoa/org/eclipse/swt/graphics/GCData.java:31 The API problem filter for: 'The field org.eclipse.swt.graphics.GCData.textStorage is no longer an API' is no longer used
Error:  Eclipse SWT/cocoa/org/eclipse/swt/graphics/GCData.java:31 The API problem filter for: 'The field org.eclipse.swt.graphics.GCData.transform is no longer an API' is no longer used
Error:  Eclipse SWT/cocoa/org/eclipse/swt/graphics/GCData.java:31 The API problem filter for: 'The field org.eclipse.swt.graphics.GCData.clipPath is no longer an API' is no longer used
Error:  Eclipse SWT/cocoa/org/eclipse/swt/graphics/GCData.java:31 The API problem filter for: 'The field org.eclipse.swt.graphics.GCData.inverseTransform is no longer an API' is no longer used
Error:  Eclipse SWT/cocoa/org/eclipse/swt/graphics/GCData.java:31 The API problem filter for: 'The field org.eclipse.swt.graphics.GCData.flippedContext is no longer an API' is no longer used
Error:  Eclipse SWT/cocoa/org/eclipse/swt/graphics/GCData.java:31 The API problem filter for: 'The field org.eclipse.swt.graphics.GCData.paintRect is no longer an API' is no longer used
Error:  Eclipse SWT/cocoa/org/eclipse/swt/graphics/GCData.java:31 The API problem filter for: 'The field org.eclipse.swt.graphics.GCData.visiblePath is no longer an API' is no longer used
Error:  Eclipse SWT/cocoa/org/eclipse/swt/graphics/GCData.java:31 The API problem filter for: 'The field org.eclipse.swt.graphics.GCData.view is no longer an API' is no longer used
Error:  Eclipse SWT/cocoa/org/eclipse/swt/graphics/GCData.java:31 The API problem filter for: 'The field org.eclipse.swt.graphics.GCData.layoutManager is no longer an API' is no longer used
Error:  Eclipse SWT/cocoa/org/eclipse/swt/graphics/GCData.java:31 The API problem filter for: 'The field org.eclipse.swt.graphics.GCData.size is no longer an API' is no longer used
Error:  Eclipse SWT/cocoa/org/eclipse/swt/graphics/GCData.java:31 The API problem filter for: 'The field org.eclipse.swt.graphics.GCData.path is no longer an API' is no longer used
Error:  Eclipse SWT/cocoa/org/eclipse/swt/graphics/GCData.java:31 The API problem filter for: 'The field org.eclipse.swt.graphics.GCData.textContainer is no longer an API' is no longer used

[laeubi]

@HeikoKlare I can't tell you exactly why but it seems more that after a release some filters become no longer required (maybe because there is a new API baseline now), but I never have digged to much into this and just removed items that are declared no longer required.

[HeikoKlare]

Alright, then it's probably fine to remove them. Even though in this case it's not a consequence of a release and thus a change in the API baseline, but a consequence of using Tycho 4.0.9 instead of 4.0.8.

Anyway, there currently is another build issue introduced by the Tycho version bump (eclipse-platform/eclipse.platform.releng.aggregator#2360 (comment)), which needs to be fixed before merging this PR makes sense.

[laeubi]

API Tools is always a mystery ;-)

I can only tell that 4.0.8 by default ships with the API-Tools 2024-03 and 4.0.9 uses API-Tools 2024-09 as a default, maybe something has changed there, I just noticed similar messages in the past.