Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand Bar is not scaled during DPI change #1528

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

Expand Bar is not scaled during DPI change #1528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/ExpandBar.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,6 +878,7 @@ private static void handleDPIChange(Widget widget, int newZoom, float scalingFac
for (ExpandItem item : expandBar.getItems()) {
DPIZoomChangeRegistry.applyChange(item, newZoom, scalingFactor);
}
expandBar.layoutItems(0, true);
expandBar.redraw();
}
}
2 changes: 1 addition & 1 deletion bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/ExpandItem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@ private static void handleDPIChange(Widget widget, int newZoom, float scalingFac
if (item.height != 0 || item.width != 0) {
int newWidth = Math.round(item.width * scalingFactor);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When testing this PR I found that this calculation only work with scale mode quarter. When using integer200, the scalingFactor is always 1, such that items are not scaled. It then looks like this:
image

Using scalingFactor does not seem to be the right thing here. @akoch-yatta do you know how we could fix tihs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scaling was broken even before and this change doesn't bring any regression. From my understanding we only care about int200 scale mode only if we are regressing something, should we try to fix it for int200?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's not a regression of this PR. Still, the rescaling behavior will still be broken after this PR due to the mentioned bug. Currently, int200 is even the more important case, since it's the default value and will be used with the experimental option for monitor-specific rescaling that we have provided. In the long term, the quarter option should of course be the default one, but for now it's not.

So it's fine for me to only address the repositioning in this PR and keep the resizing for later. We should just make sure that we have an issue to track that and address it as a follow-up task.

Copy link
Contributor Author

@ShahzaibIbrahim ShahzaibIbrahim Nov 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created a new issue in our backlog for resizing in int200 case, https://github.com/orgs/vi-eclipse/projects/1/views/1?pane=issue&itemId=86212846

Repositioning is correct I think?

int newHeight = Math.round(item.height * scalingFactor);
item.setBoundsInPixels(item.x, item.y, newWidth, newHeight, false, true);
item.setBoundsInPixels(item.x, item.y, newWidth, newHeight, true, true);
}
}
}
Loading