[win32] possible wrong zoom set for system font #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 483 files ±0 483 suites ±0 8m 17s ⏱️ - 1m 3s For more details on these failures, see this check. Results for commit 7bf9b0a. ± Comparison against base commit 99f374d. ♻️ This comment has been updated with latest results. |
HeikoKlare
reviewed
Oct 31, 2024
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/internal/ScalingSWTFontRegistry.java
Outdated
Show resolved
Hide resolved
akoch-yatta
force-pushed
the
scaling-system-font-initialization
branch
from
6f0d60a
to
35dd671
Compare
HeikoKlare
force-pushed
the
scaling-system-font-initialization
branch
from
35dd671
to
9141dc8
Compare
HeikoKlare
approved these changes
Nov 1, 2024
This commit adapts the initialization of a new base system font in the ScalingSWTFontRegistry to ensure the correct zoom is set at initialization. contributes to eclipse-platform#62 and eclipse-platform#127
HeikoKlare
force-pushed
the
scaling-system-font-initialization
branch
from
9141dc8
to
7bf9b0a
Compare
|
Failing tests are unrelated and documented: #1564 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the initialization of a new base system font in the ScalingSWTFontRegistry to ensure the correct zoom is set at initialization.
I am not aware of any real issue caused by a wrong zoom value, but not using the targetZoom here is a possible source of errors.