Edge: Implement AuthenticationListener handling for BasicAuth

[sratz]

Differences to IE engine:

• Location attribute:
  • IE does not provide the 'location' for the callback, so this has to be guessed from lastNavigateURL which does not work consistently, e.g. after an immediate Browser.setUrl();
  • Edge does provide the 'location' information consistently
• When returning invalid credentials
  • IE does not call the authentication handler again for further attempts
  • Edge calls the authentication handler again and again. Keeping track of this is out-of-scope for SWT. There is no retryCount field or similar in the event. AuthenticationHandler implementations need to account for unbounded repetitive calls in case the server does not bail out.

Resolves #730.

[sratz]

Can be manually tested, e.g. using https://httpbin.org:

import org.eclipse.swt.SWT;
import org.eclipse.swt.browser.Browser;
import org.eclipse.swt.layout.FillLayout;
import org.eclipse.swt.widgets.Display;
import org.eclipse.swt.widgets.Shell;

public class EdgeAuth {

	public static void main(String[] args) {
		Display display = new Display();
		Shell shell = new Shell(display);
		shell.setLayout(new FillLayout());
		Browser browser = new Browser(shell, SWT.EDGE);
		browser.addAuthenticationListener(event -> {
			System.out.println(event.location);

			// testable scenarios

			{
				// 1: fallback to browser dialog
			}

			{
				// 2: failure (causing repeated calls)
				event.user = "foo";
				event.password = "WRONG";
			}

			{
				// 3: correct credentials
				event.user = "foo";
				event.password = "bar";
			}

			{
				// 4: cancel authentication
				event.doit = false;
			}

		});
		browser.setUrl("https://httpbin.org/basic-auth/foo/bar");
		shell.open();
		while (!shell.isDisposed()) {
			if (!display.readAndDispatch())
				display.sleep();
		}
		display.dispose();
	}

}

[github-actions]

Test Results

   483 files  ±0     483 suites  ±0   9m 10s ⏱️ + 1m 19s
 4 095 tests ±0   4 085 ✅ ±0   7 💤 ±0  3 ❌ ±0 
16 173 runs  ±0  16 080 ✅ ±0  90 💤 ±0  3 ❌ ±0 

For more details on these failures, see this check.

Results for commit 4858107. ± Comparison against base commit ce2795a.

[HeikoKlare]

The code looks good and works as expected. Differences to IE sound okay or even beneficial.

Implementing the commented out code in ICoreWebView2BasicAuthenticationRequestedEventArg sounds reasonable, but from my side would not be necessary if it is currently not used anymore. Feel free to decide whether you want to change/add that. My approval holds no matter whether that change is made.

[sratz]

The code looks good and works as expected. Differences to IE sound okay or even beneficial.

Thanks for reviewing. Agreed, the Edge behavior feels better / more intuitive.

Implementing the commented out code in ICoreWebView2BasicAuthenticationRequestedEventArg sounds reasonable, but from my side would not be necessary if it is currently not used anymore. Feel free to decide whether you want to change/add that. My approval holds no matter whether that change is made.

I added the method implementation so the interface definition is complete.

[sratz]

Test failures on Linux are unrelated.