Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize browser tests to allow executing them for Edge browser #671 #1572

Merged

Conversation

HeikoKlare
Copy link
Contributor

@HeikoKlare HeikoKlare commented Nov 5, 2024

Browser tests were only executed for the default configuration of a system's browser using the SWT.NONE flag. Other configurations, such as using the Edge browser in Windows, were not tested.

This change parameterizes the browser tests to also allow executing them for Edge browser on Windows. Due to current issues with the tests in the CI, this change only adds the parameterization but does not add Edge as a parameter yet.

This prepares for finally activating automated tests for Edge browser and thus contributes to #671

This is extracted from:

…clipse-platform#671

Browser tests were only executed for the default configuration of a
system's browser using the SWT.NONE flag. Other configurations, such as
using the Edge browser in Windows, were not tested.

This change parameterizes the browser tests to also allow executing them
for Edge browser on Windows. Due to current issues with the tests in the
CI, this change only adds the parameterization but does not add Edge as
a parameter yet.

Contributes to
eclipse-platform#671
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Test Results

   483 files  ±0     483 suites  ±0   7m 49s ⏱️ - 1m 25s
 4 095 tests ±0   4 085 ✅ ±0   7 💤 ±0  3 ❌ ±0 
16 173 runs  ±0  16 080 ✅ ±0  90 💤 ±0  3 ❌ ±0 

For more details on these failures, see this check.

Results for commit 178a507. ± Comparison against base commit 5aeb924.

This pull request removes 189 and adds 189 tests. Note that renamed tests count towards both.
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_callback
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_callback_afterPageReload
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_callback_with_String
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_callback_with_boolean
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_callback_with_integer
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_callback_with_javaReturningInt
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_callback_with_javaReturningString
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_callback_with_multipleValues
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_multiprocess
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_ClearAllSessionCookies
…
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_callback[browser flags: 0]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_callback_afterPageReload[browser flags: 0]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_callback_with_String[browser flags: 0]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_callback_with_boolean[browser flags: 0]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_callback_with_integer[browser flags: 0]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_callback_with_javaReturningInt[browser flags: 0]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_callback_with_javaReturningString[browser flags: 0]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_callback_with_multipleValues[browser flags: 0]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_multiprocess[browser flags: 0]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_ClearAllSessionCookies[browser flags: 0]
…
This pull request removes 2 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both.
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_ClearAllSessionCookies
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_get_set_Cookies
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_ClearAllSessionCookies[browser flags: 0]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_get_set_Cookies[browser flags: 0]

@HeikoKlare HeikoKlare marked this pull request as ready for review November 5, 2024 14:19
@HeikoKlare
Copy link
Contributor Author

Failing tests are documented and unrelated: #1564

@HeikoKlare HeikoKlare merged commit a588c9a into eclipse-platform:master Nov 5, 2024
12 of 14 checks passed
@HeikoKlare HeikoKlare deleted the issue-671-non-activate branch November 5, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant