Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkinsfile: Not fail build on failed test #1739

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Jenkinsfile: Not fail build on failed test #1739

merged 2 commits into from
Mar 7, 2024

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Mar 7, 2024

Not fail build on failed test, to still show the ecj warnings if tests fail. Copied from jdt

Not fail build on failed test, to still show the ecj warnings if tests fail.
Copied from jdt
@jukzi
Copy link
Contributor Author

jukzi commented Mar 7, 2024

Currently all builds fail due to unrelated swt change, which has the effect that no warnings are shown.
With this change the build will only show unstable result but also related warnings.

Copy link
Contributor

github-actions bot commented Mar 7, 2024

Test Results

   917 files  ±0     917 suites  ±0   36m 34s ⏱️ - 1m 43s
 7 452 tests ±0   7 297 ✅  - 2  151 💤 ±0  4 ❌ +2 
21 932 runs  ±0  21 541 ✅  - 2  386 💤 ±0  5 ❌ +2 

For more details on these failures, see this check.

Results for commit 5e167bc. ± Comparison against base commit 2f9bb90.

♻️ This comment has been updated with latest results.

@jukzi
Copy link
Contributor Author

jukzi commented Mar 7, 2024

[Pipeline] archiveArtifacts
Archiving artifacts
‘*.log’ doesn’t match anything, but ‘tests/org.eclipse.ui.tests/target/work/data/.metadata/*.log’ does. Perhaps that’s what you mean?
No artifacts found that match the file pattern "*.log,*/target/work/data/.metadata/*.log,*/tests/target/work/data/.metadata/*.log,apiAnalyzer-workspace/.metadata/*.log". Configuration error?

huh?

@mickaelistria
Copy link
Contributor

The message is relatively clear, it tells that the regexp doesn't match any file. The regexp could add tests/‘tests/*/target/work/data/.metadata/*.log

@jukzi
Copy link
Contributor Author

jukzi commented Mar 7, 2024

The build now shows the warnings, is marked as unstable but still "fails" on github - as supposed
image
image
image
the *.log error is unrelated

@jukzi jukzi merged commit 7572bd4 into master Mar 7, 2024
9 of 16 checks passed
@jukzi jukzi deleted the jukzi-patch-1 branch March 7, 2024 21:10
jukzi added a commit to eclipse-platform/eclipse.platform that referenced this pull request Mar 8, 2024
jukzi added a commit to eclipse-platform/eclipse.platform that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants