Reduce freeze times on updating search results on resource changes #2288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raghucssit : I had not enough time to play with this patch today, but it seemed to work (on top of your #2280). Could you please double check that that works as expected? |
jukzi
reviewed
Sep 18, 2024
| * @since 3.17 | ||
| */ | ||
| public boolean hasMatches() { | ||
| for (Entry<Object, Set<Match>> entry : fElementsToMatches.entrySet()) { |
There was a problem hiding this comment.
when only values are needed better iterate over Map.values()
|
@iloveeclipse I tested this PR. Changes LGTM. |
If the search view shows ~100000 matches, deleting resources that are shown in the search view freezes Eclipse for many minutes. With this change the freeze is only about 30 seconds. See eclipse-platform#2279
iloveeclipse
force-pushed
the
issue_2279_extra
branch
from
675c75d
to
89ac102
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the search view shows ~100000 matches, deleting resources that are shown in the search view freezes Eclipse for many minutes. With this change the freeze is only about 30 seconds.
See #2279
To test, perform steps from #2279 and after search results view shows matches, delete generated files in Package Explorer.