Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the missing Notification snippets to the wiki #2493

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

vogella
Copy link
Contributor

@vogella vogella commented Nov 5, 2024

Since a while we have three notification snippets but only on the documentation page.

Since a while we have three notification snippets but only on the
documentation page.
@vogella
Copy link
Contributor Author

vogella commented Nov 5, 2024

I think @wimjongman requested that a long time ago....

@vogella
Copy link
Contributor Author

vogella commented Nov 5, 2024

The macs tests failures seems unrelated.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Test Results

 1 821 files  +  1   1 821 suites  +1   1h 55m 11s ⏱️ + 1m 42s
 7 724 tests ±  0   7 494 ✅  -   1  228 💤 ±0  1 ❌ ±0  1 🔥 +1 
24 333 runs  +118  23 584 ✅ +117  747 💤 ±0  1 ❌ ±0  1 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit 9d55707. ± Comparison against base commit 9474c95.

Copy link
Contributor

@wimjongman wimjongman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Lars!

@vogella
Copy link
Contributor Author

vogella commented Nov 5, 2024

Mac failure is known: #370

@vogella vogella merged commit 136afb4 into eclipse-platform:master Nov 5, 2024
10 of 14 checks passed
@vogella vogella deleted the snippets-wiki branch November 5, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants