Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ant BuildTests fail since I20240126-1800 #1155

Closed
jukzi opened this issue Jan 29, 2024 · 1 comment · Fixed by #1156
Closed

ant BuildTests fail since I20240126-1800 #1155

jukzi opened this issue Jan 29, 2024 · 1 comment · Fixed by #1156
Assignees
@akurtakov
Labels
regression Regression defect test junit test related things

Comments

@jukzi
Copy link
Contributor

jukzi commented Jan 29, 2024

6 org.eclipse.ant.tests.ui.BuildTests fail on all platforms since
https://download.eclipse.org/eclipse/downloads/drops4/I20240126-1800/testResults.php

for example
Incorrect number of messages logged for build. Should be 8. Was 9 expected:<8> but was:<9>

java.lang.AssertionError: Incorrect number of messages logged for build. Should be 8. Was 9 expected:<8> but was:<9>
at org.eclipse.ant.tests.ui.BuildTests.testXmlLoggerListener(BuildTests.java:169)
@jukzi jukzi added regression Regression defect test junit test related things labels Jan 29, 2024
@jukzi jukzi changed the title BuildTests fail since I20240126-1800 ant BuildTests fail since I20240126-1800 Jan 29, 2024
@akurtakov
Copy link
Member

This is on me and caused by #1152 . Tests work successfully in Maven. I managed to figure out that in workspace if pde.core is not on the classpath everything is fine, but if pde.core is there exactly the same failures happen. I have to figure out how/why I-builds test runner includes it and stop this from happening.

@akurtakov akurtakov self-assigned this Jan 29, 2024
akurtakov added a commit to akurtakov/eclipse.platform that referenced this issue Jan 29, 2024
@akurtakov
Do not override eclipse.buildScript in ant.tests.ui
80b459a 
This prevents the message for overriding existing ant task that causes
failures in BuildTests.
Fixes eclipse-platform#1155
akurtakov added a commit to akurtakov/eclipse.platform that referenced this issue Jan 29, 2024
@akurtakov
Do not override eclipse.buildScript in ant.tests.ui
cd0e140 
This prevents the message for overriding existing ant task that causes
failures in BuildTests.
Fixes eclipse-platform#1155
@akurtakov akurtakov mentioned this issue Jan 29, 2024
Merged
akurtakov added a commit that referenced this issue Jan 29, 2024
@akurtakov
Do not override eclipse.buildScript in ant.tests.ui
d848e69 
This prevents the message for overriding existing ant task that causes
failures in BuildTests.
Fixes #1155
Michael5601 pushed a commit to CodeLtDave/eclipse.platform that referenced this issue Feb 12, 2024
@akurtakov @Michael5601
Do not override eclipse.buildScript in ant.tests.ui
9449204 
This prevents the message for overriding existing ant task that causes
failures in BuildTests.
Fixes eclipse-platform#1155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akurtakov akurtakov

Labels
regression Regression defect test junit test related things
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not override eclipse.buildScript in ant.tests.ui akurtakov/eclipse.platform
2 participants
@akurtakov @jukzi