Eslint is executed from the root #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaisalmen
force-pushed
the
eslint-global
branch
from
ede6c7f
to
4787ce3
Compare
- Unify eslint & tsconfig - Don't lint top-level config files
kaisalmen
force-pushed
the
eslint-global
branch
from
4787ce3
to
681dc6c
Compare
|
Sorry, I produced a merge commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move eslint execution to the main
package.json.Remove the need for base configuration, This applies both to tsconfig and eslint config. Every sub-tsconfig defines their own includes and excludes. VSCode configures its behaviour from the global the
tsconfig.json, too that's why it makes sense to feed both eslint and vscode from the same file.Removed unneeded exclusions and fixed all eslint issues.
Included
lintstep in GitHub Actions.