Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deselect nodes even if select feature of clicked is disabled #401

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

jbicker
Copy link
Contributor

@jbicker jbicker commented Nov 8, 2023

Fixes #128

deselects selected nodes
even if the clicked element has no selectFeature enabled

deselects selected nodes
even if the clicked element has no selectFeature enabled

Signed-off-by: Jan Bicker <[email protected]>
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behavior after this change looks good. But I'd like to have a second tester to be sure, @dhuebner would you have a look, too?

Copy link
Contributor

@dhuebner dhuebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with all the examples. Works as expected.

@dhuebner dhuebner merged commit f785425 into eclipse-sprotty:master Nov 9, 2023
2 checks passed
@spoenemann spoenemann added this to the v1.1.0 milestone Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deselect when select feature is disabled
3 participants