Moved feature interfaces to sprotty-protocol #413
Conversation
There was a problem hiding this comment.
From what I can see there are some features that are not moved:
- LayoutableChild
- LayoutContainer
- Decoration
- CreatingOnDrag
- Deletable
- EditableLabel
- WithEditableLabel
- Locateable
- Nameable
- Connectable
Any reason why those are not moved?
Should the symbols also be moved to sprotty-protocol?
There was a problem hiding this comment.
For code organization, I am wondering if it would make more sense to move the features interfaces into their own features.ts instead of model.ts
There was a problem hiding this comment.
Moving the existing features like BoundsAware would be a breaking change because with CommonJS imports you can import directly from sprotty-protocol/lib/model. We can consider a reorganization when we switch to ESM and package exports.
|
@gfontorbe I moved Locateable. The problem with LayoutableChild and LayoutContainer is that they extend BoundsAware, but the definition of BoundsAware in the external model ( The other features are either empty interfaces (Decoration, Deletable) or are used only in the frontend AFAICT. |
|
|
||
| export interface SShapeElement extends SModelElement, Partial<BoundsAware> { | ||
| layoutOptions?: ModelLayoutOptions | ||
| export interface SShapeElement extends SModelElement, Partial<LayoutableChild> { |
There was a problem hiding this comment.
SShapeElement is not BoundsAware anymore. Was that intended?
SNode, SPort, and SLabel don't have position and size anymore, or do I overlook something?
There was a problem hiding this comment.
Ah, it is inherited via LayoutableChild? The name is a bit misleading, isn't it?
There was a problem hiding this comment.
Do you have an alternative proposal?
I moved most of the feature interfaces to the
sprotty-protocolpackage so we can use them there. The old definitions are deprecated and can be removed in v2.0.0.