Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated extensions #53

Merged
merged 1 commit into from
Mar 1, 2020
Merged

Remove deprecated extensions #53

merged 1 commit into from
Mar 1, 2020

Conversation

vince-fugnitto
Copy link
Member

Removes deprecated extensions from both the browser and electron examples.

Signed-off-by: Vincent Fugnitto [email protected]

Removes deprecated extensions from both the `browser` and `electron` examples.

Signed-off-by: Vincent Fugnitto <[email protected]>
@vince-fugnitto
Copy link
Member Author

@akosyakov we'd need to release the update so issues such as eclipse-theia/theia#7248 do not occur for users.

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@vince-fugnitto vince-fugnitto merged commit 3594d1f into master Mar 1, 2020
@vince-fugnitto vince-fugnitto deleted the vf/deprecated branch March 1, 2020 12:26
@vince-fugnitto
Copy link
Member Author

looks good

Thank you! Would it be possible to do a release?

@marcdumais-work
Copy link
Contributor

Thank you! Would it be possible to do a release?

Yes, I will do it

@vince-fugnitto
Copy link
Member Author

Thank you! Would it be possible to do a release?

Yes, I will do it

Thank you @marcdumais-work!

@marcdumais-work
Copy link
Contributor

Done. @vince-fugnitto would you give a try from a fresh version pulled from npm?

@vince-fugnitto
Copy link
Member Author

Done. @vince-fugnitto would you give a try from a fresh version pulled from npm?

It worked correctly, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants