Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theia 1.52.0 #379

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Theia 1.52.0 #379

merged 2 commits into from
Jul 29, 2024

Conversation

sgraband
Copy link
Contributor

What it does

  • update to latest Theia
  • increase ci to macos-14

How to test

Build and check everything is still working

Review checklist

Reminder for reviewers

* update to latest Theia
* increase ci to macos-14
@jfaltermeier
Copy link
Contributor

Regarding the python version that misses on Mac. This was pinned to the used version quite some time ago: #236
We should try 3.11 as on the main theia repo. Maybe this was just an issue with 3.11.0 back then after it was released.

Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the Mac Workflow Python issue it looks good

@sgraband sgraband merged commit eee0a28 into master Jul 29, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants