Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composing-applications: reference latest over next #403

Closed
vince-fugnitto opened this issue Mar 13, 2023 · 2 comments · Fixed by #405
Closed

composing-applications: reference latest over next #403

vince-fugnitto opened this issue Mar 13, 2023 · 2 comments · Fixed by #405

Comments

@vince-fugnitto
Copy link
Member

Description

The Build your own IDE/Tool documentation references the next version of Theia dependencies which can be error prone, and result in a mismatch of extensions if a publish failed. Given these reasons downstream extenders should more likely use latest which is properly published as is the basis for releases.

The fix would be to replace uses of next with latest in the documentation:

{
"private": true,
"dependencies": {
"@theia/callhierarchy": "next",
"@theia/file-search": "next",
"@theia/git": "next",
"@theia/markers": "next",
"@theia/messages": "next",
"@theia/mini-browser": "next",
"@theia/navigator": "next",
"@theia/outline-view": "next",
"@theia/plugin-ext-vscode": "next",
"@theia/preferences": "next",
"@theia/preview": "next",
"@theia/search-in-workspace": "next",
"@theia/terminal": "next"
},
"devDependencies": {
"@theia/cli": "next"
}
}

{
"private": true,
"dependencies": {
"@theia/callhierarchy": "next",
"@theia/file-search": "next",
"@theia/git": "next",
"@theia/markers": "next",
"@theia/messages": "next",
"@theia/navigator": "next",
"@theia/outline-view": "next",
"@theia/plugin-ext-vscode": "next",
"@theia/preferences": "next",
"@theia/preview": "next",
"@theia/search-in-workspace": "next",
"@theia/terminal": "next",
"@theia/vsx-registry": "next"
},
"devDependencies": {
"@theia/cli": "next"
},
"scripts": {
"prepare": "yarn run clean && yarn build && yarn run download:plugins",
"clean": "theia clean",
"build": "theia build --mode development",
"start": "theia start --plugins=local-dir:plugins",
"download:plugins": "theia download:plugins"
},
"theiaPluginsDir": "plugins",
"theiaPlugins": {
"vscode-builtin-extensions-pack": "https://open-vsx.org/api/eclipse-theia/builtin-extension-pack/1.50.1/file/eclipse-theia.builtin-extension-pack-1.50.1.vsix"
},
"theiaPluginsExcludeIds": [
"ms-vscode.js-debug-companion",
"vscode.extension-editing",
"vscode.git",
"vscode.git-ui",
"vscode.github",
"vscode.github-authentication",
"vscode.microsoft-authentication"
]
}

@JonasHelming
Copy link
Contributor

@vince-fugnitto Do you have a fix ready? I also made a note to fix this...

@vince-fugnitto
Copy link
Member Author

@vince-fugnitto Do you have a fix ready? I also made a note to fix this...

@FernandoAscencio is planning on working on a quick fix.

FernandoAscencio added a commit to FernandoAscencio/theia-website that referenced this issue Mar 13, 2023
This commit closes eclipse-theia#403

Signed-Off-By: FernandoAscencio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants