Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] remove reference and badge to AppVeyor #64

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

vince-fugnitto
Copy link
Member

Fixes #63

Description:

Additional Info

  • The badge displayed an old build which was failing meaning
    the failed state would always be displayed unless the badge
    is removed.

Signed-off-by: Vincent Fugnitto [email protected]

Fixes eclipse-theia#63

Description:

- Remove the reference and badge to `AppVeyor` since
the CI integration no longer exists in the main repository as
of eclipse-theia/theia#6179.

Additional Info

- The badge displayed an old build which was failing meaning
the failed state would always be displayed unless the badge
is removed.

Signed-off-by: Vincent Fugnitto <[email protected]>
Copy link
Member

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching this!

@vince-fugnitto
Copy link
Member Author

LGTM, thanks for catching this!

Thanks! Unfortunately I do not have merge access.

@jankeromnes
Copy link
Member

Oops, me neither. @nisarhassan12 please merge this Pull Request when you have time. :)

@nisarhassan12 nisarhassan12 merged commit 4c8bf84 into eclipse-theia:master Jan 8, 2020
@vince-fugnitto vince-fugnitto deleted the vf/GH-63 branch January 8, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[doc] remove appveyor references and badge
3 participants