Handle the case where no default terminal profile is set no startup. F…

…ixes #12119 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <[email protected]>
eclipse-theia · Feb 21, 2023 · 798366f · 798366f
1 parent 5611541
commit 798366f
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/packages/terminal/src/browser/terminal-frontend-contribution.ts b/packages/terminal/src/browser/terminal-frontend-contribution.ts
@@ -254,9 +254,9 @@ export class TerminalFrontendContribution implements FrontendApplicationContribu
         });
         this.mergePreferencesPromise = this.mergePreferencesPromise.finally(() => this.mergePreferences());
 
+        // extension contributions get read after this point: need to set the default profile if necessary
         this.profileService.onAdded(id => {
-            // extension contributions get read after this point: need to set the default profile if necessary
-            let defaultProfileId;
+            let defaultProfileId: string | undefined;
             switch (OS.backend.type()) {
                 case OS.Type.Windows: {
                     defaultProfileId = this.terminalPreferences['terminal.integrated.defaultProfile.windows'];
@@ -271,7 +271,9 @@ export class TerminalFrontendContribution implements FrontendApplicationContribu
                     break;
                 }
             }
-            this.profileService.setDefaultProfile(defaultProfileId);
+            if (defaultProfileId) {
+                this.profileService.setDefaultProfile(defaultProfileId);
+            }
         });
     }